Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pnpm/actions-setup version to 4.0.0 #43

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

zaporter-work
Copy link
Member

@zaporter-work zaporter-work commented Jul 3, 2024

pnpm/pnpm#6424

Causing

Running self-installer...
   WARN  GET https://registry.npmjs.org/pnpm error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
   WARN  GET https://registry.npmjs.org/pnpm error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
   ERR_PNPM_META_FETCH_FAIL  GET https://registry.npmjs.org/pnpm: Value of "this" must be of type URLSearchParams
Error: Something went wrong, self-installer exits with code 1

in app

More info in private slack thread https://viaminc.slack.com/archives/C02KFSY4H89/p1720023335832159

@@ -4,6 +4,7 @@ on:
pull_request:
branches:
- main
- zp-bump
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove before merge

@zaporter-work zaporter-work changed the title Bump action versions Bump pnpm/actions-setup version to 4.0.0 Jul 3, 2024
@zaporter-work zaporter-work merged commit 7e4e4f1 into viamrobotics:main Jul 3, 2024
3 checks passed
@zaporter-work zaporter-work deleted the zp-bump branch July 3, 2024 16:49
@lord-Sid
Copy link

lord-Sid commented Jul 3, 2024

After this bump, our action started failing ->

Can you please look into it. Thanks

image

@zaporter-work
Copy link
Member Author

@lord-Sid Are you able to share your github actions / github repo that this is failing on?

@lord-Sid
Copy link

lord-Sid commented Jul 3, 2024

@zaporter-work This is my test.yml actions file contents ->

name: Run Tests and Linters
on:
workflow_dispatch:
pull_request:

jobs:
test:
runs-on: ubuntu-latest
steps:
- name: 📥 Checkout code
uses: actions/checkout@v3

  - name: 🏭 Setup pnpm
    uses: pnpm/action-setup@v2
    with:
      version: 8.6.9

  - name: 📦 Install dependencies
    run: pnpm install --frozen-lockfile

  - name: 💠 Generate Prisma Client
    run: pnpm run prisma-generate --generator client

  - name: 💅 Run linter
    run: pnpm lint

  - name: 🧪 Run tests with coverage
    run: pnpm test:cov --coverageReporters json-summary

  - name: 💬 Coverage Comment
    uses: MishaKav/jest-coverage-comment@main

@zaporter-work
Copy link
Member Author

zaporter-work commented Jul 3, 2024

@lord-Sid I suspect your issue was not caused by us (because you don't seem to be using viamrobotics/js-config (unless you are doing it elsewhere)), instead, I suspect we both ran into the same issue.

I suspect you need to change your setup-pnpm to be:

  - name: 🏭 Setup pnpm
    uses: pnpm/action-setup@23657c8550e9be4f7ee7e9d7fe8adda6d703bb4e # v4.0.0
    with:
      version: 8.6.9

@lord-Sid
Copy link

lord-Sid commented Jul 3, 2024

@zaporter-work Thanks ! It was indeed same issue. Bump up to v4 fixed it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants