-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pnpm/actions-setup version to 4.0.0 #43
Conversation
.github/workflows/ci.yaml
Outdated
@@ -4,6 +4,7 @@ on: | |||
pull_request: | |||
branches: | |||
- main | |||
- zp-bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove before merge
@lord-Sid Are you able to share your github actions / github repo that this is failing on? |
@zaporter-work This is my test.yml actions file contents -> name: Run Tests and Linters jobs:
|
@lord-Sid I suspect your issue was not caused by us (because you don't seem to be using viamrobotics/js-config (unless you are doing it elsewhere)), instead, I suspect we both ran into the same issue. I suspect you need to change your setup-pnpm to be:
|
@zaporter-work Thanks ! It was indeed same issue. Bump up to v4 fixed it :) |
pnpm/pnpm#6424
Causing
in app
More info in private slack thread https://viaminc.slack.com/archives/C02KFSY4H89/p1720023335832159