RSDK-8819: Instrument some grpc/webrtc FTDC stats. #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgottlieb
commented
Nov 7, 2024
rpc/wrtc_server.go
Outdated
| TotalTimeConnectingMillis: srv.counters.TotalTimeConnectingMillis.Load(), | ||
| } | ||
| ret.PeersActive = ret.PeersConnected - ret.PeersDisconnected | ||
| ret.AverageTimeConnectingMillis = float64(ret.TotalTimeConnectingMillis) / float64(ret.PeersConnected) |
There was a problem hiding this comment.
The graph for this was all zeroes. The values this is derived from looked good so I need to figure out what happened here.
There was a problem hiding this comment.
Figured this out. Because PeersConnected starts at 0, golang assigns NaN to AverageTimeConnectingMillis.
And the ftdc format did not see that going from nan -> y(es)an as a "diff".
viambot
added
safe to test
benjirewis
reviewed
Nov 7, 2024
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some (minimal) RDK changes to get this hooked up. Here's an example of how these stats show up.
edit Oops, the "web service" was already a component. So we get double stats in that image!