Handle temp PR envs

viamrobotics · Nov 19, 2024 · 15a4230 · 15a4230
1 parent d2f5cb9
commit 15a4230
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/web/backto.go b/web/backto.go
@@ -1,7 +1,9 @@
 package web
 
 import (
+	"fmt"
 	"net/url"
+	"regexp"
 	"strings"
 )
 
@@ -12,6 +14,18 @@ var hostnameWhitelist = map[string]bool{
 }
 
 func isWhitelisted(hostname string) bool {
+	fmt.Printf("hostname: %v\n", hostname)
+
+	regex, err := regexp.Compile("pr-(\\d+)-appmain-bplesliplq-uc.a.run.app")
+	if err != nil {
+		fmt.Errorf("Error compiling regex for whitelisted hostnames: %+v", err)
+		return false
+	}
+
+	if regex.MatchString(hostname) {
+		return true
+	}
+
 	return hostnameWhitelist[hostname]
 }
 

diff --git a/web/backto_test.go b/web/backto_test.go
@@ -64,4 +64,19 @@ func TestIsValidBacktoURL(t *testing.T) {
 		test.That(t, IsValidBacktoURL("http://localhost"), test.ShouldBeTrue)
 		test.That(t, IsValidBacktoURL("http://localhost/some/path"), test.ShouldBeTrue)
 	})
+
+	t.Run("rejects invalid temp PR env URLs", func(t *testing.T) {
+		test.That(t, IsValidBacktoURL("http://pr-1-appmain-bplesliplq-uc.a.run.app"), test.ShouldBeFalse)
+		test.That(t, IsValidBacktoURL("ftp://pr-12-appmain-bplesliplq-uc.a.run.app"), test.ShouldBeFalse)
+		test.That(t, IsValidBacktoURL("://pr-123-appmain-bplesliplq-uc.a.run.app"), test.ShouldBeFalse)
+		test.That(t, IsValidBacktoURL("//pr-1234-appmain-bplesliplq-uc.a.run.app"), test.ShouldBeFalse)
+		test.That(t, IsValidBacktoURL("//pr-12345-appmain-bplesliplq-uc.a.run.app/some/path"), test.ShouldBeFalse)
+		test.That(t, IsValidBacktoURL("pr-1234-appmain-bplesliplq-uc.a.run.app"), test.ShouldBeFalse)
+		test.That(t, IsValidBacktoURL("pr-123-appmain-bplesliplq-uc.a.run.app/some/path"), test.ShouldBeFalse)
+	})
+
+	t.Run("accepts valid temp PR env URLs", func(t *testing.T) {
+		test.That(t, IsValidBacktoURL("https://pr-12345-appmain-bplesliplq-uc.a.run.app"), test.ShouldBeTrue)
+		test.That(t, IsValidBacktoURL("https://pr-6789-appmain-bplesliplq-uc.a.run.app/some/path"), test.ShouldBeTrue)
+	})
 }