Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA-3440 Add ExportTabularData + deprecate TabularDataByFilter #595

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

DATA-3440 Add ExportTabularData + deprecate TabularDataByFilter #595

wants to merge 6 commits into from
+2,387 −828

Conversation

katiepeters
Copy link
Member

@katiepeters katiepeters commented Nov 21, 2024 •
edited
Loading

  • Adds ExportTabularData method to data service API.
  • Marks TabularDataByFilter (and related types) as deprecated.

@github-actions github-actions bot added the safe to test committer is a member of this org label Nov 21, 2024
@katiepeters katiepeters added the ready-for-protos add this when you want protos to compile on every commit label Nov 21, 2024
@katiepeters katiepeters marked this pull request as ready for review November 21, 2024 19:36
@katiepeters katiepeters removed protos-compiled ready-for-protos add this when you want protos to compile on every commit labels Nov 21, 2024
@katiepeters katiepeters added the ready-for-protos add this when you want protos to compile on every commit label Nov 21, 2024
@katiepeters katiepeters removed protos-compiled ready-for-protos add this when you want protos to compile on every commit labels Nov 21, 2024
@katiepeters katiepeters added the ready-for-protos add this when you want protos to compile on every commit label Nov 21, 2024
@dmhilly dmhilly removed their request for review November 21, 2024 20:29
@dmhilly
Copy link
Member

dmhilly commented Nov 21, 2024

I'm going to let Vijay take this one since it's just an API change!

vijayvuyyuru
vijayvuyyuru approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@vijayvuyyuru vijayvuyyuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

proto/viam/app/data/v1/data.proto
message ExportTabularDataRequest {
string part_id = 1;
string resource_name = 2;
string resource_subtype = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[supernit] I think this should be resource type instead of subtype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijayvuyyuru vijayvuyyuru vijayvuyyuru approved these changes

Assignees
No one assigned
Labels
protos-compiled ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katiepeters @dmhilly @vijayvuyyuru