-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add username to ProcessConfig proto #580
Add username to ProcessConfig proto #580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
for clarity -- this only works with processes, not with modules? (or do modules already have a way to do it?)
@abe-winter This would only add it to processes -- not modules. Modules have no way to set a username and it would probably take a lot more work to add to modules. |
Oops -- forgot to add @cheukt for code-owner approval. |
See comments here: viamrobotics/docs#3649
Looks like username was never actually added to the protos -- so it doesn't work in the UI.
I'm not sure if you ever expected this to be used in the UI.
@abe-winter We have a few options from here: