Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username to ProcessConfig proto #580

Merged

Conversation

zaporter-work
Copy link
Member

@zaporter-work zaporter-work commented Nov 1, 2024

See comments here: viamrobotics/docs#3649

Looks like username was never actually added to the protos -- so it doesn't work in the UI.

I'm not sure if you ever expected this to be used in the UI.

@abe-winter We have a few options from here:

  • Don't document username (not sure if it was ever supposed to be used from the app config)
  • Add username to the protos (Are you hesitant about adding to protos?)

@github-actions github-actions bot added the safe to test committer is a member of this org label Nov 1, 2024
Copy link
Member

@abe-winter abe-winter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

for clarity -- this only works with processes, not with modules? (or do modules already have a way to do it?)

@abe-winter abe-winter added the ready-for-protos add this when you want protos to compile on every commit label Nov 1, 2024
@zaporter-work
Copy link
Member Author

@abe-winter This would only add it to processes -- not modules. Modules have no way to set a username and it would probably take a lot more work to add to modules.

@abe-winter abe-winter removed the ready-for-protos add this when you want protos to compile on every commit label Nov 1, 2024
@zaporter-work
Copy link
Member Author

Oops -- forgot to add @cheukt for code-owner approval.

@zaporter-work zaporter-work added the ready-for-protos add this when you want protos to compile on every commit label Nov 5, 2024
@zaporter-work zaporter-work removed the ready-for-protos add this when you want protos to compile on every commit label Nov 5, 2024
@zaporter-work zaporter-work merged commit 3212b33 into viamrobotics:main Nov 5, 2024
3 checks passed
@zaporter-work zaporter-work deleted the zp/add-username-to-proto branch November 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protos-compiled safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants