Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-6881] Add disable wifi power save option #43

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

ale7714
Copy link
Member

@ale7714 ale7714 commented Nov 19, 2024

No description provided.

if isNew {
w.logger.Infof("Updated %s to: %q", wifiPowerSaveFilepath, contents)
// Reload NetworkManager to apply changes
if err := w.nm.Reload(0); err != nil {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed looking at network manager logs that the config file logs without warning or errors

@ale7714
Copy link
Member Author

ale7714 commented Nov 19, 2024

@Otterverse I can only get the change to apply by actually rebooting the device. Rebooting NetworkManager is not enough. Maybe am I missing something?

I tried:

		err := w.settings.ReloadConnections()
		if err != nil {
			return errw.Wrap(err, "error reloading connections after wifi-powersave.conf update")
		}

and while i see on the networkmanager logs Nov 19 02:26:34 raspberrypi NetworkManager[589]: <info> [1731983194.6017] audit: op="connections-reload" pid=1104 uid=0 result="success"

I don't really see powersave changing. Rebooting the pi does work.

@Otterverse Otterverse changed the title [APP-6881] Add disabale wifi power save option [APP-6881] Add disable wifi power save option Nov 20, 2024
Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we can get a beta out tomorrow and start some testing.

@ale7714 ale7714 merged commit b19180f into main Nov 20, 2024
2 checks passed
@ale7714 ale7714 deleted the disable-wifi-power-save branch November 20, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants