[APP-5742] Fix nil pointer bugs (#19)

networkmanager/grpc.go

@@ -41,7 +41,6 @@ func (w *NMWrapper) GetSmartMachineStatus(ctx context.Context,
 	defer w.dataMu.Unlock()
 
 	w.state.setLastInteraction()
-	lastNetwork := w.networks[w.lastSSID].getInfo()
 
 	ret := &pb.GetSmartMachineStatusResponse{
 		ProvisioningInfo: &pb.ProvisioningInfo{
@@ -51,10 +50,15 @@ func (w *NMWrapper) GetSmartMachineStatus(ctx context.Context,
 		},
 		HasSmartMachineCredentials: w.state.getConfigured(),
 		IsOnline:                   w.state.getOnline(),
-		LatestConnectionAttempt:    provisioning.NetworkInfoToProto(&lastNetwork),
 		Errors:                     w.errListAsStrings(),
 	}
 
+	lastNetwork, ok := w.networks[w.lastSSID]
+	if ok {
+		lastNetworkInfo := lastNetwork.getInfo()
+		ret.LatestConnectionAttempt = provisioning.NetworkInfoToProto(&lastNetworkInfo)
+	}
+
 	// reset the errors, as they were now just displayed
 	w.errors = nil
 
@@ -78,8 +82,11 @@ func (w *NMWrapper) SetNetworkCredentials(ctx context.Context,
 	w.input.PSK = req.GetPsk()
 	w.inputReceived.Store(true)
 
-	if req.GetSsid() == w.lastSSID {
-		w.networks[w.lastSSID].lastError = nil
+	if req.GetSsid() == w.lastSSID && w.lastSSID != "" {
+		lastNetwork, ok := w.networks[w.lastSSID]
+		if ok {
+			lastNetwork.lastError = nil
+		}
 	}
 
 	return &pb.SetNetworkCredentialsResponse{}, nil

networkmanager/portal.go

@@ -204,8 +204,11 @@ func (w *NMWrapper) portalSave(resp http.ResponseWriter, req *http.Request) {
 			w.banner += "Added credentials for SSID: " + w.input.SSID
 		}
 
-		if ssid == w.lastSSID && w.networks[w.lastSSID] != nil {
-			w.networks[w.lastSSID].lastError = nil
+		if ssid == w.lastSSID && ssid != "" {
+			lastNetwork, ok := w.networks[w.lastSSID]
+			if ok {
+				lastNetwork.lastError = nil
+			}
 		}
 		w.input.Updated = time.Now()
 		w.inputReceived.Store(true)