Make qmk_settings respect AUTO_SHIFT definitions. #225
Conversation
|
Definitely open to suggestions on how to make the bit sets consistent. |
|
This looks like it'd cause auto shift to always be enabled when qmk settings are enabled, since Vial sets vial-qmk/builddefs/common_features.mk Line 589 in 955da77 |
|
Ah... that's a bummer. Looking closer I think I can change it to use AUTO_SHIFT_DISABLED_AT_STARTUP from https://github.com/vial-kb/vial-qmk/blob/vial/quantum/process_keycode/process_auto_shift.c#L24 and then set that by default in common_features.mk to keep the previous behavior? |
|
(and then users could un-define it if they want it enabled at startup) Another thing I could do would be to invert this define? It doesn't seem to be documented anywhere, and clearly has no effect in Vial currently. Looks like this was added in qmk/qmk_firmware#14201... WDYT? |
Previously when `qmk_settings_reset()` was called, it would always reset `auto_shift` to 0 (i.e. totally disabled). With this change, all defined AUTO_SHIFT config macros will instead be used as the default value. To avoid changing the default behavior, this keeps AUTO_SHIFT off by default unless the user #undef's AUTO_SHIFT_DISABLED_AT_STARTUP.
riannucci
force-pushed
the
auto-shift-settings
branch
from
1b404e6 to
c858a8b
Compare
|
OK, updated this to use AUTO_SHIFT_DISABLED_AT_STARTUP, which shouldn't affect existing vial configs. |
Previously when
qmk_settings_reset()was called, it would alwaysreset
auto_shiftto 0 (i.e. totally disabled). With this change,all defined AUTO_SHIFT config macros will instead be used as the
default value.