Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Caps Word #196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jurica
Copy link

@jurica jurica commented Aug 7, 2023

@xyzz
Copy link
Contributor

xyzz commented Aug 12, 2023

Caps word isn't present on protocol v5, it should be removed, and then it's the same issue as in #191 (comment) to hide it in the UI when unsupported

@jurica
Copy link
Author

jurica commented Aug 13, 2023

@xyzz thanks for the feedback, I wasn't aware of that.
I thought about a solution for the problem and came around with the following approach: extend Keycode class by a property "min_protocol". This makes it possible to filter out keycodes not supported by the selected keyboard. (This would also allow to extend it further with a property max_protocol if later versions drop a keycode.)

Unfortunately I only got this working here if I put the "Quantum keys" on an own tab only containing these keys.
I'm not sure if this is due to how things get set up in tabbed_keycodes.py or my environment (I'm on macOS on an Apple Silicon machine and was not able to get Python 3.6 and PyQt5 set up, so I upgraded Vial to PyQt6 in order to be able to do some development. But my Qt6 port is not yet fully working.).

Looking forward some feedback on my approach.

@lesshonor
Copy link
Contributor

lesshonor commented Sep 9, 2023

It's worth nothing that the hex code for Caps Word did exist and function back in "v5" even if it wasn't exposed in the GUI, and there are records of that hex code's use in the Vial discord at least as far back as September 2022.

@philliphall
Copy link

Just adding a plus one for this feature :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants