Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playlist): usage of new youtube api format for playlists/albums #1654

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LlinksRechts
Copy link

@LlinksRechts LlinksRechts commented Jun 24, 2024

About a week ago, youtube apparently changed it's api, breaking a lot of apps like this one (see #1632, #1652, #1650, #1649, #1648, #1647, #1646, #1645, #1644, #1643, #1640, #1638, #1636, #1634, #1639); this is a rather quick-and-dirty fix to extract playlist/album info after this api change.

For everyone that cannot wait until this gets merged (if it does) and can't build the app themselves:

DOWNLOAD HERE ↓↓↓

app-release.zip

DISCLAIMER

You will not be able to install this over an existing install from eg. f-droid because this apk is not signed and I don't have the keys to do so. You should be able to uninstall and then install this version, but note that ALL YOUR DATA WILL BE GONE, so back up before.

DOWNLOAD HERE ↑↑↑

Update 2024-06-30:

The problem was there also for the song list of an artist - this is fixed now too.

Update 2024-07-04:

As @andietablante18 pointed out, artist names were not shown in song search results; this now works again as well.

Update 2024-07-07:

Old databases may contain cached information scraped using the wrong api format and are thus still displayed as 'Unknown'; this patch now updates these albums as they are loaded. Thanks @KingK2-gif for the reproducing example.

@LlinksRechts LlinksRechts changed the title fix(playlist): usage of new youtube api format for playlists fix(playlist): usage of new youtube api format for playlists/albums Jun 24, 2024
@zyqunix
Copy link

zyqunix commented Jun 24, 2024

Hey! Do you know how and where to fix this? I have modded my own ViMusic, and I'm wondering where and how to change the API.

@LlinksRechts
Copy link
Author

@zyqunix I'm not sure what you mean - the fix is here in this PR, so if you have your own fork you can probably just take my commit (ed8e9bf) and copy it to your fork

@zyqunix
Copy link

zyqunix commented Jun 24, 2024

i have my own fork, correct. I copied everything from your fork into mine and it still says "Unknown"

@LlinksRechts
Copy link
Author

@zyqunix hmm weird, for me this works without any problems, you have a repo somewhere I can take a look at? have you actually rebuilt and reinstalled (dumb question i know, but just making sure)? only other thing I could think of is that theres somehow differences in the api you get vs what I see, maybe regional?

@zyqunix
Copy link

zyqunix commented Jun 24, 2024

I don't have an actual repo on github, but i can make one if you want. I'm using Android Studio with the newest updates too. If you need to contact me outside of GitHub, just tell me, but I also want to help other people find their solutions here.

@zyqunix
Copy link

zyqunix commented Jun 24, 2024

the rep is here: https://github.com/zyqunix/ZyMusic

@LlinksRechts
Copy link
Author

@zyqunix seems like ur missing the changes in innertube/src/main/kotlin/it/vfsfitvnm/innertube/models/SectionListRenderer.kt

@zyqunix
Copy link

zyqunix commented Jun 24, 2024

oh okay, thank you a LOT

@zyqunix
Copy link

zyqunix commented Jun 24, 2024

@LlinksRechts
epic 2089
still doesn't really work

@LlinksRechts
Copy link
Author

@zyqunix honestly I don't know if I can really help you here then - I compiled your version (with the 2 additional lines in the file I mentioned) and it works perfectly fine for me... maybe its the specific album you're using? which one is that so I can try?

@Opposite34
Copy link

I really hope the maintainer sees this, since this is a breaking change. I do not mind if an app doesn't update all that much, but this is something you cannot really ignore.

@zyqunix
Copy link

zyqunix commented Jun 25, 2024

@LlinksRechts i just pressed a random The Weeknd album on the start, i can also try building it into an app and installing it on my phone.

@zyqunix
Copy link

zyqunix commented Jun 25, 2024

@LlinksRechts could you send the apk you built?

@ChubbyLlama
Copy link

@zyqunix I'm not sure what you mean - the fix is here in this PR, so if you have your own fork you can probably just take my commit (ed8e9bf) and copy it to your fork

Where do I find the fork

@ChubbyLlama
Copy link

Why don't they just add updates I don't know how to code this stuff

@zyqunix
Copy link

zyqunix commented Jun 25, 2024

Why don't they just add updates I don't know how to code this stuff

me neither 😭😭

@ChubbyLlama
Copy link

@LlinksRechts could you send the apk you built?

If you get it send to me please

@zyqunix
Copy link

zyqunix commented Jun 26, 2024

@LlinksRechts i do not have telegram. i have discord or instagram however. zyqunix on discord and zyq_un on instagram.

@zyqunix
Copy link

zyqunix commented Jun 26, 2024

@LlinksRechts could you send the apk you built?

If you get it send to me please

i could send you my custom app with more colors if i build it. it's the same name, but a different logo. also the font was changed to Lexend, which is easier to read for dyslexic people. read the comment above if you want to add me on either of those platforms

@linfan18REAL
Copy link

Hello, I am having the same problem and I know NOTHING about code, any help?

@LlinksRechts
Copy link
Author

@linfan18REAL @ChubbyLlama scroll all the way up to the top to the description, download apk (app-release.zip), install on phone

@andietablante18
Copy link

The music artists' name still won't show after the song searching is over.

@andietablante18
Copy link

Thank you for this immediate response! I am happy that it is now functioning properly.

@andietablante18
Copy link

Also, I am looking forward to this APK's future features. I suggest adding interactable widgets and customizable playlist cover. Once again, thank you for the immediate action.

@KingK2-gif
Copy link

Hi, for me the redownload works and it fixes the issue with the albums but when I try and restore my data it goes back to having some albums unknown again.

@LlinksRechts
Copy link
Author

@KingK2-gif can you send me your database so I can reproduce this?

@KingK2-gif
Copy link

@mvaishwarya
Copy link

@LlinksRechts
I thought I had nowhere to go once the ViMusic stopped working. I was hesitant to download this patch but glad I did! It works fine! Thank you for fixing it!
P.S.: Is there any Telegram channel to know the latest bugs/fixes for ViMusic that are in-progress/done on Git? If not, can you please consider this? Thanks again for resolving this.

@LlinksRechts
Copy link
Author

@mvaishwarya I'm not really associated with the original devs of this app, I'm just some guy who wants to use the app and fixed it because no one else did, so I don't really think I should take over like this just yet... depending how this plays out (app seems unmaintained rn...) I might consider permanently maintaining a fork some day

@Dibestitw
Copy link

About a week ago, youtube apparently changed it's api, breaking a lot of apps like this one (see #1632, #1652, #1650, #1649, #1648, #1647, #1646, #1645, #1644, #1643, #1640, #1638, #1636, #1634, #1639); this is a rather quick-and-dirty fix to extract playlist/album info after this api change.

For everyone that cannot wait until this gets merged (if it does) and can't build the app themselves:

DOWNLOAD HERE ↓↓↓

app-release.zip

DISCLAIMER

You will not be able to install this over an existing install from eg. f-droid because this apk is not signed and I don't have the keys to do so. You should be able to uninstall and then install this version, but note that ALL YOUR DATA WILL BE GONE, so back up before.

DOWNLOAD HERE ↑↑↑

Update 2024-06-30:

The problem was there also for the song list of an artist - this is fixed now too.

Update 2024-07-04:

As @andietablante18 pointed out, artist names were not shown in song search results; this now works again as well.

Update 2024-07-07:

Old databases may contain cached information scraped using the wrong api format and are thus still displayed as 'Unknown'; this patch now updates these albums as they are loaded. Thanks @KingK2-gif for the reproducing example.

@Dibestitw
Copy link

I downloaded the app-release but I don't know what to do after that, can someone help me?
(Sorry for my ignorance but it's my first time having problems with ViMusic in general)

@KingK2-gif
Copy link

@LlinksRechts @Dibestitw Thankyou it finally works now. Thx.

@Dibestitw
Copy link

I actually still got the problem, basically when I try to download/update the zip, it says that there's a conflict with an existing pack

@Zac2406
Copy link

Zac2406 commented Jul 8, 2024

@Zac2406 you can't install as an update because this apk is not signed as the original one is (and I don't have the key to do that); you can uninstall and install again, but be aware that all your data will be gone. that it doesn't work on another device is a bit weird, it does for me and seems to for everyone else here as well... you installed the apk from this thread and get the same 'undefined' behavior as before?

yes I installed the apk from the given link on this thread but anyways I found a new app now called InnerTune.

@Dibestitw
Copy link

Thanks, I solved the problem, what I did was backup my ViMusic, uninstall, download the zip and last restore my data and now it all works perfectly.
Thank y'all so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet