-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(playlist): usage of new youtube api format for playlists/albums #1654
base: master
Are you sure you want to change the base?
Conversation
Hey! Do you know how and where to fix this? I have modded my own ViMusic, and I'm wondering where and how to change the API. |
i have my own fork, correct. I copied everything from your fork into mine and it still says "Unknown" |
@zyqunix hmm weird, for me this works without any problems, you have a repo somewhere I can take a look at? have you actually rebuilt and reinstalled (dumb question i know, but just making sure)? only other thing I could think of is that theres somehow differences in the api you get vs what I see, maybe regional? |
I don't have an actual repo on github, but i can make one if you want. I'm using Android Studio with the newest updates too. If you need to contact me outside of GitHub, just tell me, but I also want to help other people find their solutions here. |
the rep is here: https://github.com/zyqunix/ZyMusic |
@zyqunix seems like ur missing the changes in |
oh okay, thank you a LOT |
@LlinksRechts |
@zyqunix honestly I don't know if I can really help you here then - I compiled your version (with the 2 additional lines in the file I mentioned) and it works perfectly fine for me... maybe its the specific album you're using? which one is that so I can try? |
I really hope the maintainer sees this, since this is a breaking change. I do not mind if an app doesn't update all that much, but this is something you cannot really ignore. |
@LlinksRechts i just pressed a random The Weeknd album on the start, i can also try building it into an app and installing it on my phone. |
@LlinksRechts could you send the apk you built? |
Why don't they just add updates I don't know how to code this stuff |
me neither 😭😭 |
If you get it send to me please |
@LlinksRechts i do not have telegram. i have discord or instagram however. zyqunix on discord and zyq_un on instagram. |
i could send you my custom app with more colors if i build it. it's the same name, but a different logo. also the font was changed to Lexend, which is easier to read for dyslexic people. read the comment above if you want to add me on either of those platforms |
Hello, I am having the same problem and I know NOTHING about code, any help? |
@linfan18REAL @ChubbyLlama scroll all the way up to the top to the description, download apk (app-release.zip), install on phone |
The music artists' name still won't show after the song searching is over. |
after youtube api update
Thank you for this immediate response! I am happy that it is now functioning properly. |
Also, I am looking forward to this APK's future features. I suggest adding interactable widgets and customizable playlist cover. Once again, thank you for the immediate action. |
Hi, for me the redownload works and it fixes the issue with the albums but when I try and restore my data it goes back to having some albums unknown again. |
@KingK2-gif can you send me your database so I can reproduce this? |
@LlinksRechts |
@mvaishwarya I'm not really associated with the original devs of this app, I'm just some guy who wants to use the app and fixed it because no one else did, so I don't really think I should take over like this just yet... depending how this plays out (app seems unmaintained rn...) I might consider permanently maintaining a fork some day |
|
I downloaded the app-release but I don't know what to do after that, can someone help me? |
@LlinksRechts @Dibestitw Thankyou it finally works now. Thx. |
I actually still got the problem, basically when I try to download/update the zip, it says that there's a conflict with an existing pack |
yes I installed the apk from the given link on this thread but anyways I found a new app now called InnerTune. |
Thanks, I solved the problem, what I did was backup my ViMusic, uninstall, download the zip and last restore my data and now it all works perfectly. |
About a week ago, youtube apparently changed it's api, breaking a lot of apps like this one (see #1632, #1652, #1650, #1649, #1648, #1647, #1646, #1645, #1644, #1643, #1640, #1638, #1636, #1634, #1639); this is a rather quick-and-dirty fix to extract playlist/album info after this api change.
For everyone that cannot wait until this gets merged (if it does) and can't build the app themselves:
DOWNLOAD HERE ↓↓↓
app-release.zip
DISCLAIMER
You will not be able to install this over an existing install from eg. f-droid because this apk is not signed and I don't have the keys to do so. You should be able to uninstall and then install this version, but note that ALL YOUR DATA WILL BE GONE, so back up before.
DOWNLOAD HERE ↑↑↑
Update 2024-06-30:
The problem was there also for the song list of an artist - this is fixed now too.
Update 2024-07-04:
As @andietablante18 pointed out, artist names were not shown in song search results; this now works again as well.
Update 2024-07-07:
Old databases may contain cached information scraped using the wrong api format and are thus still displayed as 'Unknown'; this patch now updates these albums as they are loaded. Thanks @KingK2-gif for the reproducing example.