Skip to content

Commit

Permalink
Merge pull request #23 from verypossible/update-to-1.26
Browse files Browse the repository at this point in the history
Bump versions of Python, SLS and yarn
  • Loading branch information
brianz authored Apr 6, 2018
2 parents 5113a26 + 466176c commit d9b04a5
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:2.7.13
FROM python:2.7.14

RUN curl -sL https://deb.nodesource.com/setup_8.x | bash -
RUN apt-get install -y \
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-python3
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.6.2
FROM python:3.6.5

RUN curl -sL https://deb.nodesource.com/setup_8.x | bash -
RUN apt-get install -y \
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
NAME = verypossible/serverless
VERSION = 1.25.0
VERSION = 1.26.1
SERVERLESS_VERSION = $(VERSION)
YARN_VERSION = 1.3.2
YARN_VERSION = 1.5.1

.PHONY: all py2 py3 shell

Expand Down
13 changes: 11 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,19 @@ using `--build-arg` during the `docker build` command. To pass this
argument, we need a Docker Cloud build hook which resides in
`hooks/build`.

# Instructions for updating versions

In order to bump the Serverless version, the only real requirement is
to change the version in the `hooks/build` file. The `Makefile` also
has references to the Serverless version, but this is really for
testing the build locally.
has references to the Serverless version, _but this is really for
testing the build locally_.

My workflow is usually:

- Update versions in `Makefile` and run `make build`
- If the build works, update the versions in `hooks/build`
- Create PR
- On merge to `master`, Docker Hub will do the builds automatically.

See the following for more information on Docker Cloud build hooks:

Expand Down
4 changes: 2 additions & 2 deletions hooks/build
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ fi
echo "Using $DOCKERFILE for build"

docker build \
--build-arg SERVERLESS_VERSION=1.25.0 \
--build-arg YARN_VERSION=1.3.2 \
--build-arg SERVERLESS_VERSION=1.26.1 \
--build-arg YARN_VERSION=1.5.1 \
-f $DOCKERFILE \
-t $IMAGE_NAME .

0 comments on commit d9b04a5

Please sign in to comment.