Improved testing using a new glob macro #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One minor concern is that I don't know how the release process will be affected. I don't actually expect the release process to be affected, since this is added only as a |
parno
approved these changes
Sep 24, 2024
jaybosamiya-ms
added a commit
that referenced
this pull request
Sep 25, 2024
This PR builds on #95, separating out the various snapshot tests that were previously merged via [`inline-crate`](https://crates.io/crates/inline-crate).
|
The release, after introducing this as a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up a new
globattribute macro, intended to be used in tests. This helps split each of the larger snapshot tests up into smaller functions, allowing for parallelism between the snapshotted files when runningcargo nextest runorcargo test.There wasn't an existing crate that I could use that had
globat macro level, and to introduce a new proc macro, we need to set up a separate crate; this is set up as a crate within the same workspace. In the future, if I find this useful for other use cases too, I might split it off as a separate crate entirely, but for now, it can sit in this workspace.It is easiest to see the impact of this change by looking at the output of
cargo nextest run(or ~equivalently,cargo test). Before this PR, the entirety ofverus-snapshot/**/*.rsran within a single test function, but after this, each file gets its own function.