Handle keyword-prefixed identifiers #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parno
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As has been noticed before, things like
aswould end up causing something likeassertto be parsed asas sert, and thus needed explicit workarounds like f7c22d7 (foras,isandhas), or 4a9d96c (forbox). #6 also is an issue of this kind (formut). Basically, we were fixing this issue as we hit it each time, in an ad-hoc way at the use site of the specific problematic prefix.This PR fixes it once and for all, by making all the strings make sure that they aren't a prefix of a longer string (by using a negative lookahead), that way the use-sites don't need to worry about these strings. Thus, this PR also cleans up the previous workarounds that were added in the past.