Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test that broadcast use items should not eat trailing spaces #53

Closed
wants to merge 1 commit into from

Conversation

utaal
Copy link
Contributor

@utaal utaal commented Apr 7, 2024

@jaybosamiya, @parno this less-opinionated one is the behavior I think would be more consistent with the other formatting rules, but I don't know how to ensure line breaks are preserved, can you folks help with this?

@jaybosamiya
Copy link
Collaborator

jaybosamiya commented Apr 9, 2024

I agree with this style change (edit: assuming you mean newlines).

Rather than "not eat trailing", it might be easier to approach this as a "always add trailing, after a broadcast use group". Will take a closer look in some time

@jaybosamiya
Copy link
Collaborator

#55 now supersedes this, imho. Please take a look if the style update there matches what you expect. Also, as I mention there, some (minor) coordination will be required with vstd, at the time of verusfmt release.

@utaal
Copy link
Contributor Author

utaal commented Apr 10, 2024

Close in favor of #55.

@utaal utaal closed this Apr 10, 2024
@jaybosamiya jaybosamiya deleted the broadcast-use-dont-eat-spaces branch April 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants