fix: gitignore composer lock #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's generally accepted that this shouldn't be committed in libraries. It has no effect on downstream installs, only for other people working on the package (and will cause issues if they have different php versions/extensions/etc).
|
I've read both pros and cons on including/excluding the lock file, and I can't really find a consensus 😅Given that's it's one line developers can add themselves, I'm leaving it in for now. That does not mean, however, that I'm closing this one. Just got to read up a little more on the subject 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's generally accepted that this shouldn't be committed in libraries. It has no effect on downstream installs, only for other people working on the package (and will cause issues if they have different php versions/extensions/etc).
Caught this because my CI build failed as I accidentally committed it
https://github.com/atymic/laravel-dateinterval-cast/runs/473557842