fix: Correct context for declaration files #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "Cannot find module 'styled-jsx' or its corresponding type declarations"
eps1lon
force-pushed
the
sebbie/05-24-test_types
branch
from
768fdba
to
aa684d5
Compare
eps1lon
commented
May 24, 2024
| @@ -124,6 +126,7 @@ | |||
| "css" | |||
| ], | |||
| "dependencies": { | |||
| "client-only": "0.0.1" | |||
| "client-only": "0.0.1", | |||
| "typescript": "~5.0.0" | |||
There was a problem hiding this comment.
>=5.1 requires Node.js 14. CI is running with 12 but this may break other stuff.
ztanner
approved these changes
May 24, 2024
|
🎉 This PR is included in version 5.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Cannot find module 'styled-jsx' or its corresponding type declarations"
The
scoped-jsxcodemod has a known, bad transform where it adds the import outside of thedeclare modulechanging the context of the declaration. This resulted instyled-jsxhaving no type declarations.Originally caught in https://github.com/vercel/next.js/actions/runs/9227067088/job/25388269813?pr=66185#step:28:384.
Added a type-checking setup to smoke test types. This would've caught this bug i.e. this PR would fail without the last commit.