perf(core): disable lastLogin update as an option #3253
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable the last login update (prevent a save on user entity) when a user logs in.
Breaking changes
No
Screenshots
context: our users need to be authenticated to view our products.
We receive a lots of request on the authenticate endpoint, and we have a bottleneck on this endpoint.
When we have too much traffic, we have locks on the ‘user’ table
Here is the request
UPDATE "user" SET "lastLogin" = $1, "updatedAt" = CURRENT_TIMESTAMP WHERE "id" IN ($2)This query is not useful for us. This PR proposes a solution to deactivate it and avoid a lock on the user table.
In terms of volume, this represents more than 250k updates of the lastLogin field per day, often at the same connection time.
Not sure where to write the tests, please let me know.
Checklist
📌 Always:
👍 Most of the time: