Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(facet-service): Ensure FacetValue retrieval is channel specific … #3216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mschipperheyn
Copy link
Collaborator

Ensures that FacetValues retrieved with Facet query are channel specific.
Related to #2882

Currently having problems running tests on my environment to verify functionality.

Description

Facets and FacetValues are channelaware. You can have a central facet that can be accessed through multiple channels. However, a number of queries in the facet service, including one used for the populate script findByCode. retrieve associated FacetValues in a non channel aware manner, leading to problems in importing and other issues when working in a multi vendor scenario

Breaking changes

Possibly. If your code assumed the non channel aware retrieval of facetValues through the now changed code

Screenshots

Checklist

📌 Always:

  • [x ] I have set a clear title
  • [x ] My PR is small and contains a single feature
  • [ x] I have checked my own PR

👍 Most of the time:

  • [ x] I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 19, 2024 3:48pm

Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

sonarcloud bot commented Nov 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant