[WIP] feat(facet-service): Ensure FacetValue retrieval is channel specific … #3216
+146
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that FacetValues retrieved with Facet query are channel specific.
Related to #2882
Currently having problems running tests on my environment to verify functionality.
Description
Facets and FacetValues are channelaware. You can have a central facet that can be accessed through multiple channels. However, a number of queries in the facet service, including one used for the
populate
scriptfindByCode
. retrieve associated FacetValues in a non channel aware manner, leading to problems in importing and other issues when working in a multi vendor scenarioBreaking changes
Possibly. If your code assumed the non channel aware retrieval of facetValues through the now changed code
Screenshots
Checklist
📌 Always:
👍 Most of the time: