Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(product-duplicator): Add source variant customFields to duplicated variant #3203

Conversation

mschipperheyn
Copy link
Collaborator

Description

Product duplicator now copies variant customFields. Fixes #3202

Breaking changes

  • This will start copying variant related customFields when you use the product duplicator with includeVariants: true. This could potentially cause unexpected side effects, if your code previously assumed those customFields were not copied.

Checklist

📌 Always:

  • [x ] I have set a clear title
  • [ x] My PR is small and contains a single feature
  • [ x] I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 15, 2024 1:33pm

Copy link
Contributor

github-actions bot commented Nov 8, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mschipperheyn
Copy link
Collaborator Author

Not sure why the CLA Assistant shows the CLA as pending

@mschipperheyn
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@michaelbromley
Copy link
Member

recheck

@michaelbromley
Copy link
Member

There seems to be a problem with the CLA bot - it is having trouble updating the JSON file. This might be due to other changes to that file since you branched off master last week. Would you mind merging master into your branch and then pushing the result to this PR?

@mschipperheyn
Copy link
Collaborator Author

There seems to be a problem with the CLA bot - it is having trouble updating the JSON file. This might be due to other changes to that file since you branched off master last week. Would you mind merging master into your branch and then pushing the result to this PR?

no prob

@mschipperheyn mschipperheyn force-pushed the fix/duplicator-variant-custom-fields branch from 35c0ad1 to 9520e00 Compare November 15, 2024 13:30
Copy link

sonarcloud bot commented Nov 15, 2024

@mschipperheyn
Copy link
Collaborator Author

@michaelbromley just a ping to get this merged in despite the CLA Assistant issue

@mschipperheyn
Copy link
Collaborator Author

Hey @michaelbromley any reason this PR is not getting merged?

@mschipperheyn
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 3, 2024
@mschipperheyn
Copy link
Collaborator Author

Finally that damned bot worked

@mschipperheyn
Copy link
Collaborator Author

@michaelbromley I see that this is still not merged. Anything I need to do from my side?

@michaelbromley michaelbromley merged commit 69a1de0 into vendure-ecommerce:master Dec 18, 2024
30 checks passed
@michaelbromley
Copy link
Member

Nope, all good now. Thanks for the contribution!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product duplicator does not copy variant customFields
2 participants