-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(product-duplicator): Add source variant customFields to duplicated variant #3203
fix(product-duplicator): Add source variant customFields to duplicated variant #3203
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
All contributors have signed the CLA ✍️ ✅ |
Not sure why the CLA Assistant shows the CLA as pending |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There seems to be a problem with the CLA bot - it is having trouble updating the JSON file. This might be due to other changes to that file since you branched off |
no prob |
35c0ad1
to
9520e00
Compare
Quality Gate passedIssues Measures |
@michaelbromley just a ping to get this merged in despite the CLA Assistant issue |
Hey @michaelbromley any reason this PR is not getting merged? |
I have read the CLA Document and I hereby sign the CLA |
Finally that damned bot worked |
@michaelbromley I see that this is still not merged. Anything I need to do from my side? |
Nope, all good now. Thanks for the contribution! |
Description
Product duplicator now copies variant customFields. Fixes #3202
Breaking changes
includeVariants: true
. This could potentially cause unexpected side effects, if your code previously assumed those customFields were not copied.Checklist
📌 Always:
👍 Most of the time: