Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(job-queue-plugin): Use multiple BullMQ queues instead of one #3108

Open
wants to merge 35 commits into
base: minor
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
664e22d
refactor(job-queue-plugin): Use multiple BullMQ queues instead of one
dlhck Oct 5, 2024
4f6cbfd
refactor(job-queue-plugin): Make queue prefix optional in custom lua …
dlhck Oct 5, 2024
d2a21ba
feat(job-queue-plugin, core): Add job queue option supportsListAllQueues
dlhck Oct 6, 2024
755f367
chore(dev-server): Disable BullMQ plugin again
dlhck Oct 6, 2024
6c97290
chore(job-queue-plugin): Remove unused code
dlhck Oct 6, 2024
d1a0b64
chore(job-queue-plugin): Update better-sqlite to 11.x for Node v22 su…
dlhck Oct 7, 2024
e7bcd31
@areg-gareginyan-im has signed the CLA in vendure-ecommerce/vendure#3220
github-actions[bot] Nov 21, 2024
1d03072
@DeltaSAMP has signed the CLA in vendure-ecommerce/vendure#3214
github-actions[bot] Nov 21, 2024
c525a61
docs: Small error in entity events (#3214)
DeltaSAMP Nov 21, 2024
9a382da
docs: update `vendure-config.ts` reference (#3228)
emmanuel-ferdman Nov 23, 2024
b6b6de6
@xiopipe has signed the CLA in vendure-ecommerce/vendure#3227
github-actions[bot] Nov 23, 2024
cb82eee
docs(admin-ui): fix ngx-translate and unicode link (#3227)
xiopipe Nov 25, 2024
666c312
@Draykee has signed the CLA in vendure-ecommerce/vendure#3231
github-actions[bot] Nov 25, 2024
fd571f5
chore: Add sonar config
michaelbromley Nov 25, 2024
3f7efc5
chore: Rename sonar config
michaelbromley Nov 25, 2024
a674c2c
chore: Attempt to fix sonarcloud paths
michaelbromley Nov 25, 2024
7ef2cfb
chore: Attempt to fix sonarcloud paths 2
michaelbromley Nov 26, 2024
2b2a09c
chore: Attempt to fix sonarcloud paths 3
michaelbromley Nov 26, 2024
c754a71
chore: Attempt to fix sonarcloud paths 4
michaelbromley Nov 26, 2024
d0e5a06
chore: Remove sonarcloud config
michaelbromley Nov 26, 2024
0f1702f
@Rana-Faraz has signed the CLA in vendure-ecommerce/vendure#3242
github-actions[bot] Nov 27, 2024
121055b
docs: Fix wishlist plugin example code (#3242)
Rana-Faraz Nov 29, 2024
7798ddc
fix(core): Fixed wrong join statement for variant on ProductVariantPr…
Draykee Nov 29, 2024
26adc93
@michaelbromley has signed the CLA in vendure-ecommerce/vendure#3208
github-actions[bot] Nov 29, 2024
8545267
fix(asset-server-plugin): Fix issues with s3/minio file retrieval
michaelbromley Nov 29, 2024
7a25bef
fix(admin-ui): Preset filters preserve query parameters (#3176)
taxilian Nov 29, 2024
adfbda6
fix(payments-plugin): False positive error logging fix in MolliePlugi…
martijnvdbrug Nov 29, 2024
8a4ab91
Merge branch 'master' into minor
michaelbromley Nov 29, 2024
f56ce3a
chore: Manually add recent change after merge
michaelbromley Nov 29, 2024
8bb5bd6
Merge branch 'minor' into fix/bullmq-single-redis-queue
michaelbromley Nov 29, 2024
613c92a
chore: Regenerate types
michaelbromley Nov 29, 2024
48dfd14
refactor(core): Move `supportsListAllQueues` out of VendureConfig
michaelbromley Nov 29, 2024
1b9c8a2
chore: Update generated types
michaelbromley Nov 29, 2024
254b025
test(job-queue-plugin): Add e2e tests for BullMQJobQueueStrategy
michaelbromley Dec 2, 2024
0367a0a
WIP: still buggy, need to revisit
michaelbromley Dec 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/docs/guides/developer-guide/events/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ type BlogPostInputTypes = CreateBlogPostInput | UpdateBlogPostInput | ID | ID[];
* This event is fired whenever a BlogPost is added, updated
* or deleted.
*/
export class BlogPostEvent extends VendureEntityEvent<BlogPost[], BlogPostInputTypes> {
export class BlogPostEvent extends VendureEntityEvent<BlogPost, BlogPostInputTypes> {
constructor(
ctx: RequestContext,
entity: BlogPost,
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/guides/developer-guide/plugins/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ export class WishlistService {
*/
async addItem(ctx: RequestContext, variantId: ID): Promise<WishlistItem[]> {
const customer = await this.getCustomerWithWishlistItems(ctx);
const variant = this.productVariantService.findOne(ctx, variantId);
const variant = await this.productVariantService.findOne(ctx, variantId);
if (!variant) {
throw new UserInputError(`No ProductVariant with the id ${variantId} could be found`);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import MemberDescription from '@site/src/components/MemberDescription';
<GenerationInfo sourceFile="packages/core/src/config/vendure-config.ts" sourceLine="1091" packageName="@vendure/core" />

All possible configuration options are defined by the
[`VendureConfig`](https://github.com/vendure-ecommerce/vendure/blob/master/server/src/config/vendure-config.ts) interface.
[`VendureConfig`](https://github.com/vendure-ecommerce/vendure/blob/master/packages/core/src/config/vendure-config.ts) interface.

```ts title="Signature"
interface VendureConfig {
Expand Down
48 changes: 48 additions & 0 deletions license/signatures/version1/cla.json
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,54 @@
"created_at": "2024-11-09T10:08:00Z",
"repoId": 136938012,
"pullRequestNo": 3205
},
{
"name": "areg-gareginyan-im",
"id": 29304156,
"comment_id": 2489024261,
"created_at": "2024-11-20T16:20:29Z",
"repoId": 136938012,
"pullRequestNo": 3220
},
{
"name": "DeltaSAMP",
"id": 47721109,
"comment_id": 2485190224,
"created_at": "2024-11-19T09:44:10Z",
"repoId": 136938012,
"pullRequestNo": 3214
},
{
"name": "xiopipe",
"id": 51303452,
"comment_id": 2495534224,
"created_at": "2024-11-23T16:40:53Z",
"repoId": 136938012,
"pullRequestNo": 3227
},
{
"name": "Draykee",
"id": 19676051,
"comment_id": 2498531458,
"created_at": "2024-11-25T16:47:49Z",
"repoId": 136938012,
"pullRequestNo": 3231
},
{
"name": "Rana-Faraz",
"id": 96161223,
"comment_id": 2503744724,
"created_at": "2024-11-27T12:25:05Z",
"repoId": 136938012,
"pullRequestNo": 3242
},
{
"name": "JavierElices",
"id": 15686364,
"comment_id": 2476096457,
"created_at": "2024-11-14T11:22:24Z",
"repoId": 136938012,
"pullRequestNo": 3208
}
]
}
2 changes: 1 addition & 1 deletion packages/admin-ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ In addition to the library, there is also a full application located at [./src/a

## Localization

Localization of UI strings is handled by [ngx-translate](http://www.ngx-translate.com/). The translation strings should use the [ICU MessageFormat](http://userguide.icu-project.org/formatparse/messages).
Localization of UI strings is handled by [ngx-translate](https://ngx-translate.org). The translation strings should use the [ICU MessageFormat](https://unicode-org.github.io/icu/userguide/format_parse/messages).

Translation keys are automatically extracted by running:
```
Expand Down
19 changes: 17 additions & 2 deletions packages/admin-ui/src/lib/core/src/common/generated-types.ts

Large diffs are not rendered by default.

Loading
Loading