Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Drop Java library #512

Merged
merged 2 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
196 changes: 0 additions & 196 deletions .github/workflows/java.yml

This file was deleted.

1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Cargo.bak.lock

# intellij
/.idea/
/java/.idea/

# pixi
/.pixi/
Expand Down
8 changes: 0 additions & 8 deletions BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,6 @@ Then launch JupyterLab
pixi run jupyter-lab
```

## Build and test Java
Build and test the VegaFusion Java package with

```
pixi run test-java
```


## Build Python packages for distribution
To build Python wheels for the current platform, the `build-py-embed`, `build-py-vegafusion`, and `build-py-jupyter` tasks may be used

Expand Down
13 changes: 0 additions & 13 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ members = [
"vegafusion-python",
"vegafusion-wasm",
"vegafusion-server",
"vegafusion-jni",
]

[workspace.dependencies]
Expand Down
24 changes: 0 additions & 24 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,30 +70,6 @@ npm run build:prod
npm publish
```

### Publish Java library
First, download and unzip the `jni-native` CI artifact. This artifact contains the compiled JNI libraries for each supported operating system and architecture.

Set the `VEGAFUSION_JNI_LIBRARIES` environment variable to the unzipped `jni-native` directory and publish the jar with `pixi run publish-java`:

```
VEGAFUSION_JNI_LIBRARIES=/path/to/jni-native pixi run publish-java
```

This publishes the jar files to OSSRH at https://s01.oss.sonatype.org/. In order to sync these files to the public maven central repository, follow the steps described in https://central.sonatype.org/publish/release/.

#### Java publication config
Publishing the Java library to maven central requires configuring the `~/.gradle/gradle.properties` file with:
```
signing.keyId=YourKeyId
signing.password=YourPublicKeyPassword
signing.secretKeyRingFile=PathToYourKeyRingFile

ossrhUsername=your-jira-id
ossrhPassword=your-jira-password
```



### Publish Rust crates
The Rust crates should be published in the following order

Expand Down
6 changes: 0 additions & 6 deletions java/.gitignore

This file was deleted.

19 changes: 0 additions & 19 deletions java/README.md

This file was deleted.

Binary file removed java/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
6 changes: 0 additions & 6 deletions java/gradle/wrapper/gradle-wrapper.properties

This file was deleted.

Loading
Loading