Bugfix panic in D3D11RenderEngine->restore #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veeenu
requested changes
Apr 28, 2024
Co-authored-by: Andrea Venuta <[email protected]>
|
Committed your suggestion and did the same bellow, plus fixed the linting error, tested and it works on remastered. |
|
Oh, right, CI fails because of the new |
|
This change is so small, I don't think there will be any issues merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When self.ps_instances is none, self.ps_instances_count is 0, then slice::from_raw_parts causes a panic here.
Same for the vs version. Initially I tried this fix with is_some() but it still caused a crash for me.
I don't know if this has any side effects, for me it renders fine after this fix.