Updated Tst autocompletion support for ct (Issue #170) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2e Test results - Vcast 2024sp5 - Group coded_tests 3 files +2 3 suites +2 7m 31s ⏱️ +29s Results for commit adbe679. ± Comparison against base commit cacd52b. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Zbigor
reviewed
Dec 20, 2024
Zbigor
reviewed
Dec 20, 2024
Zbigor
reviewed
Dec 20, 2024
Zbigor
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Looks alright. It would make sense to add a couple more e2e tests for the completion itself (suggested unit/function) and to cover that wider range indicated by codecov (the single line special failure cases aren't as important). The comment about a possible refactor could be turned into an "internal issue"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates script editing to support coded tests and resolves #170.
Added
Syntax Support for
TEST.CODED_TEST_FILE:TEST.CODED_TEST_FILEas a valid syntax in.tstfiles.TEST.CODED_TEST_FILEafter typingTEST..:.Behavior When
TEST.SUBPROGRAMiscoded_tests_driver:TEST.CODED_TEST_FILEwithout error diagnostics.TEST.VALUEandTEST.EXPECTEDlines, ensuring they give error diagnostics.Behavior When
TEST.SUBPROGRAMis Notcoded_tests_driver:TEST.CODED_TEST_FILE, ensuring it gives an error diagnostic.coded_tests_driverfrom the subprogram list forTEST.VALUEandTEST.EXPECTEDlines.Error Handling Enhancements:
Tests
Autocompletion list for
TEST.SUBPROGRAMwithout using the fakeTEST.VALUElineTEST.SUBPROGRAM, we need the<unit>fromTEST.UNIT.getNearest()intstCompletion.ts.<unit>is sent as an additional parameter to the Python logic.processSubprogramLines()(tstUtilities.py), we use this<unit>to retrieve, withgetFunctions(), theautocompletionlist of all the functions in this unit from theDataAPI.<<INIT>>, <<COMPOUND>>, <<coded_tests_driver>>.