Fix CAN ID and CAN Flag Transformation to SIL Kit API Enumerators #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer checklist (address before review)
Subject
What kind of changes does this pull request comprise?
Description
These changes fix an issue that was noticed by a user of SIL Kit in Issue 54.
In SocketCAN the
can_id
field of thestruct can_frame
also contains the EFF (IDE), RTR, and ERR flags in the upper three bits. These are however never masked when the frame is forwarded to SIL Kit.Additionally, this PR drops Error-Frames (ERR flag set) and produces an error-level log message, since Error-Frames are currently not supported by SIL Kit.
Review assignments
Testing instructions (e.g., for specific setups)
You can verify that an issue existed by using
cansend
with an extended identifier, e.g.,cansend vcan0 18FDE5FF#13140003FF006601
after bringing up the CAN device.