Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CAN ID and CAN Flag Transformation to SIL Kit API Enumerators #2

Closed

Conversation

VDanielEdwards
Copy link
Member

Developer checklist (address before review)

  • Documentation updated (public API changes only)

Subject

What kind of changes does this pull request comprise?

  • Feature
  • Bug fix
  • Documentation update
  • other (please specify below)

Description

These changes fix an issue that was noticed by a user of SIL Kit in Issue 54.

In SocketCAN the can_id field of the struct can_frame also contains the EFF (IDE), RTR, and ERR flags in the upper three bits. These are however never masked when the frame is forwarded to SIL Kit.

Additionally, this PR drops Error-Frames (ERR flag set) and produces an error-level log message, since Error-Frames are currently not supported by SIL Kit.

Review assignments

  • review code
  • check new/modified tests (does it make sense? does it cover the functionality sufficiently?)
  • run functional tests manually
  • run specific setup (e.g., demos)
  • other (please specify below)

Testing instructions (e.g., for specific setups)

You can verify that an issue existed by using cansend with an extended identifier, e.g., cansend vcan0 18FDE5FF#13140003FF006601 after bringing up the CAN device.

@VDanielEdwards
Copy link
Member Author

Small addendum to the testing instructions: use the CAN demo from SIL Kit (in CanReader mode with the --async flag) to verify that the ID and the flags are correctly transformed.

@VDanielEdwards VDanielEdwards changed the title Fix CAN ID and CAN Flag Tranformation to SIL Kit API Enumerators Fix CAN ID and CAN Flag Transformation to SIL Kit API Enumerators Jun 11, 2024
@VDanielEdwards
Copy link
Member Author

This issue is handled internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant