SKA-485: remove the publish when an error occurs in advalues mode (#14)

vectorgrp · Apr 24, 2024 · 6227032 · 6227032
1 parent c5ffe85
commit 6227032
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/advalues/adapter/AdAdapter.cpp b/advalues/adapter/AdAdapter.cpp
@@ -94,6 +94,8 @@ auto AdAdapter::Serialize() -> std::vector<uint8_t>
         }
 
         _logger->Debug("Serializing data and publishing on topic: " + _publishTopic);
+
+        return serializer.ReleaseBuffer();
     }
     catch (const std::out_of_range& e)
     {
@@ -108,7 +110,7 @@ auto AdAdapter::Serialize() -> std::vector<uint8_t>
         _logger->Error("Something went wrong when trying to serialize data on " + _publishTopic + ": " + e.what());
     }
 
-    return serializer.ReleaseBuffer();
+    return std::vector<uint8_t>{};
 }
 
 // Deserialize received values 

diff --git a/chardev/adapter/ChardevAdapter.cpp b/chardev/adapter/ChardevAdapter.cpp
@@ -87,7 +87,10 @@ void ChardevAdapter::Publish()
 {
     if (!_publishTopic.empty())
     {
-        _publisher->Publish(Serialize());
+        if (const auto& bytes = Serialize(); !bytes.empty())
+        {
+            _publisher->Publish(bytes);
+        }
     }
 }