SKA-403: fix advalues check regression

vectorgrp · May 13, 2024 · 40a935f · 40a935f
1 parent af36e63
commit 40a935f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/advalues/adapter/AdAdapter.cpp b/advalues/adapter/AdAdapter.cpp
@@ -62,7 +62,7 @@ auto AdAdapter::Serialize() -> std::vector<uint8_t>
         }
         case enum_uint8_t:
         {
-            uint8_t value = isValidData<uint8_t, int64_t>(str);
+            uint8_t value = isValidData<uint8_t, uint64_t>(str);
             serializer.Serialize(bufferFromChardevTo<uint16_t>(), 8);
             break;
         }
@@ -133,14 +133,14 @@ void AdAdapter::Deserialize(const std::vector<uint8_t>& bytes)
     case enum_uint8_t:
     {
         std::stringstream ss;
-        ss << static_cast<int>(deserializer.Deserialize<int16_t>(8));
+        ss << static_cast<int>(deserializer.Deserialize<uint16_t>(8));
         str = ss.str();
         break;
     }
     case enum_int8_t:
     {
         std::stringstream ss;
-        ss << static_cast<int>(deserializer.Deserialize<uint16_t>(8));
+        ss << static_cast<int>(deserializer.Deserialize<int16_t>(8));
         str = ss.str();
         break;
     }

diff --git a/advalues/adapter/AdAdapter.hpp b/advalues/adapter/AdAdapter.hpp
@@ -128,7 +128,7 @@ auto AdAdapter::isValidData(const std::string& str) -> T
     }
     else if (std::is_unsigned_v<T>)
     {
-        if (!isHexa)
+        if (isHexa)
         {
             value = std::stoull(str, nullptr, 0);
         }