fix(reduce): properly support nested fields #20776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: transforms
pront
changed the title
pront
force-pushed
the
pront/reduce-repo
branch
2 times, most recently
from
fd56fce
to
534fb46
Compare
pront
commented
Jul 2, 2024
src/transforms/reduce/transform.rs
Outdated
| tx.send(e_2.into()).await.unwrap(); | ||
|
|
||
| let output = out.recv().await.unwrap().into_log(); | ||
| assert_eq!(output["a.b"], json!([1,2]).into()); |
There was a problem hiding this comment.
thread 'transforms::reduce::transform::test::nested_path_strat' panicked at src/transforms/reduce/transform.rs:810:13:
assertion `left == right` failed
left: Integer(1)
right: Array([Integer(1), Integer(2)])
Notes:
self.fields: {KeyString("c"): AddNumbersMerger { v: Int(777) }, KeyString("message"): DiscardMerger { v: Bytes(b"test message 1") }, KeyString("a"): DiscardMerger { v: Object({KeyString("b"): Integer(1)}) }, KeyString("timestamp"): TimestampWindowMerger { started: 2024-07-02T22:13:38.074593Z, latest: 2024-07-02T22:13:38.074593Z }}
strategies: {KeyString("a.b"): Array}
The fields map doesn't have a key a.b.
pront
changed the title
pront
changed the title
github-actions
bot
added
domain: external docs
pront
force-pushed
the
pront/reduce-repo
branch
3 times, most recently
from
6ccf778
to
e1c8169
Compare
pront
commented
Jul 3, 2024
| @@ -118,7 +118,7 @@ releases: "0.39.0": { | |||
| { | |||
| type: "chore" | |||
| description: """ | |||
| The deprecated `enterprise` feature and global configuration option has been removed. | |||
| The deprecated `enterprise` feature and global configuration option has been removed. See the upgrade guide for details. | |||
There was a problem hiding this comment.
No idea how this ended up in here.
|
closed in favor of #20790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #17637