Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trailing slash to aws endpoint examples #20774

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Add trailing slash to aws endpoint examples #20774

merged 2 commits into from
Jul 3, 2024

Conversation

scohajo
Copy link
Contributor

@scohajo scohajo commented Jul 2, 2024

@scohajo scohajo requested review from a team as code owners July 2, 2024 20:04
@bits-bot
Copy link

bits-bot commented Jul 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jul 2, 2024
@scohajo scohajo mentioned this pull request Jul 2, 2024
Closed
jszwedko
jszwedko approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @scohajo

@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jul 2, 2024
@jszwedko
Copy link
Member

jszwedko commented Jul 2, 2024

I think we just need you to accept the CLA above when you get a moment.

@scohajo
Copy link
Contributor Author

scohajo commented Jul 2, 2024

@jszwedko accepted! Sorry on the delay there

@jszwedko jszwedko enabled auto-merge July 2, 2024 20:38
@jszwedko
Copy link
Member

jszwedko commented Jul 2, 2024

No worries! Appreciate the contribution!

auto-merge was automatically disabled July 2, 2024 22:22

Head branch was pushed to by a user without write access

@scohajo
Copy link
Contributor Author

scohajo commented Jul 2, 2024

@hestonhoffman sorry I think it failed because I forgot to cue fmt

@jszwedko jszwedko enabled auto-merge July 3, 2024 13:13
@jszwedko jszwedko added this pull request to the merge queue Jul 3, 2024
Merged via the queue into vectordotdev:master with commit e1ca0f1 Jul 3, 2024
49 checks passed
jszwedko added a commit that referenced this pull request Jul 3, 2024
@jszwedko
chore(docs): Regenerate component docs
c47e788 
Was missed in #20774 because the check didn't run.

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko mentioned this pull request Jul 3, 2024
Open
jszwedko added a commit that referenced this pull request Jul 3, 2024
@jszwedko
Revert "Add trailing slash to aws endpoint examples (#20774)"
b18e529 
This reverts commit e1ca0f1.
@jszwedko jszwedko mentioned this pull request Jul 3, 2024
Merged
jszwedko added a commit that referenced this pull request Jul 3, 2024
@jszwedko
chore(docs): Document that AWS endpoint config needs to have a trai…
462c4a4 
…ling `/`

Recreates #20774

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko mentioned this pull request Jul 3, 2024
Open
jszwedko added a commit that referenced this pull request Jul 3, 2024
@jszwedko
chore(ci): Run component docs check if component cue files change
9924852 
Avoids breakages like the one introduced by #20774

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko mentioned this pull request Jul 3, 2024
Open
@jszwedko
Copy link
Member

jszwedko commented Jul 3, 2024

I realized this actually updated the wrong place: the cue files directly rather than the doc comments. I open #20791 to revert and #20792 to reintroduce.

github-merge-queue bot pushed a commit that referenced this pull request Jul 3, 2024
@jszwedko
chore(ci): Revert "Add trailing slash to aws endpoint examples" (#20791)
0088883 
Revert "Add trailing slash to aws endpoint examples (#20774)"

This reverts commit e1ca0f1.
pront added a commit that referenced this pull request Jul 5, 2024
@pront
fix(reduce): aggregate nested fields
fec6e8b 
chore(ci): Revert "Add trailing slash to aws endpoint examples" (#20791)

Revert "Add trailing slash to aws endpoint examples (#20774)"

This reverts commit e1ca0f1.

Handle full event paths

wip

spell checker

fix bad rebase
pront added a commit that referenced this pull request Jul 5, 2024
@pront
fix(reduce): aggregate nested fields
290c92e 
chore(ci): Revert "Add trailing slash to aws endpoint examples" (#20791)

Revert "Add trailing slash to aws endpoint examples (#20774)"

This reverts commit e1ca0f1.

Handle full event paths

wip

spell checker

fix bad rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

@hestonhoffman hestonhoffman hestonhoffman approved these changes

Assignees
No one assigned
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear to include trailing slash / in endpoint URL
4 participants
@scohajo @bits-bot @jszwedko @hestonhoffman