Chunk Data/Text frames by outboundMaxFrameSize. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishnash
force-pushed
the
ChunkDataAndTextFramesBasedOnMaxFrameSize
branch
2 times, most recently
from
d41f457
to
d8a861a
Compare
hishnash
commented
Jul 22, 2021
hishnash
force-pushed
the
ChunkDataAndTextFramesBasedOnMaxFrameSize
branch
from
d8a861a
to
a415f12
Compare
This change fixes a bug when sending text/data that was large WebsocketKit did not chunk these text/data into mutliple frames.
hishnash
force-pushed
the
ChunkDataAndTextFramesBasedOnMaxFrameSize
branch
from
a415f12
to
91d92c1
Compare
…rames being sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug when sending text/data that was large
WebSocketKitdid not chunk these text/data into multiple frames.