Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PMCE on WebSockets #145

Closed
wants to merge 131 commits into from
Closed

Support PMCE on WebSockets #145

wants to merge 131 commits into from

Conversation

jhoughjr
Copy link
Collaborator

@jhoughjr jhoughjr commented Jul 31, 2023

This adds PMCE class to handle compression/decompression. A PR is pending in the vapor repo so it can be easily used inside of vapor.

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, a couple notations

Sources/WebSocketKit/PMCE.swift Outdated Show resolved Hide resolved
Sources/WebSocketKit/PMCE.swift Outdated Show resolved Hide resolved
Sources/WebSocketKit/PMCE.swift Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #145 (342c578) into main (a935b63) will decrease coverage by 26.82%.
Report is 1 commits behind head on main.
The diff coverage is 17.14%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #145       +/-   ##
===========================================
- Coverage   82.85%   56.03%   -26.82%     
===========================================
  Files           6        7        +1     
  Lines         659     1085      +426     
===========================================
+ Hits          546      608       +62     
- Misses        113      477      +364     
Files Changed Coverage Δ
Sources/WebSocketKit/PMCE.swift 1.94% <1.94%> (ø)
Sources/WebSocketKit/WebSocket.swift 73.17% <40.69%> (-15.88%) ⬇️
Sources/WebSocketKit/WebSocketHandler.swift 58.02% <51.72%> (-4.48%) ⬇️
Sources/WebSocketKit/WebSocketClient.swift 90.67% <60.00%> (-4.68%) ⬇️
...urces/WebSocketKit/HTTPUpgradeRequestHandler.swift 73.77% <100.00%> (+1.84%) ⬆️

... and 1 file with indirect coverage changes

@jhoughjr
Copy link
Collaborator Author

jhoughjr commented Nov 7, 2023

Hummingbird will take flight as Vapor dissipates into nothingness.

@jhoughjr jhoughjr closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants