Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requesting on-demand inputs when using valohai input utilities #137

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

hylje
Copy link
Contributor

@hylje hylje commented Dec 12, 2024

If accessing inputs using valohai.input('...') that have not been downloaded, check if we have the necessary input metadata and API endpoint access to get download URLs for those inputs and download them before proceeding.

@hylje hylje force-pushed the on-demand-inputs branch 4 times, most recently from 2ed6d46 to c61852a Compare December 12, 2024 13:41
Copy link
Contributor

@teroyks teroyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a lot of setup in the test! : )
Looks good and clean to me!

Comment on lines +19 to +20
monkeypatch.setenv("VH_INPUTS_DIR", str(vte.inputs_path))
monkeypatch.setenv("VH_OUTPUTS_DIR", str(vte.outputs_path))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😃

@hylje hylje merged commit e4dcf3a into master Dec 20, 2024
5 checks passed
@hylje hylje deleted the on-demand-inputs branch December 20, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants