Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default Python image #136

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Update default Python image #136

merged 1 commit into from
Dec 11, 2024

Conversation

teroyks
Copy link
Contributor

@teroyks teroyks commented Dec 11, 2024

Using a more modern Python image by default instead of one way past end of life.

vh yaml step FILE.PY uses this image as a default.

There have been some issues e.g. with PyTorch with images newer than 3.11, so we’ll use that as the default for now.

The slim image is much smaller (~87%) than the regular Python image, and should work with most things just fine, so setting that as the default is good for making the executions more nimble.

@teroyks teroyks self-assigned this Dec 11, 2024
@teroyks teroyks marked this pull request as ready for review December 11, 2024 14:13
@teroyks teroyks requested review from akx and ruksi December 11, 2024 14:13
valohai/consts.py Outdated Show resolved Hide resolved
3.11 is a safe version -- newer ones still sometimes have issues with
e.g. PyTorch.

Use the slim variant, as that makes the executions both smaller and
faster (the slim image is ~87% smaller than the default Python image).
@teroyks teroyks force-pushed the update-default-python-image branch from 465e40f to ab087d1 Compare December 11, 2024 14:38
@akx akx changed the title Update default Python image to 3.13 Update default Python image Dec 11, 2024
@teroyks teroyks requested a review from akx December 11, 2024 14:42
@teroyks
Copy link
Contributor Author

teroyks commented Dec 11, 2024

Discussion on the topic

Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ⬆️

@ruksi ruksi merged commit 51dfaaf into master Dec 11, 2024
5 checks passed
@ruksi ruksi deleted the update-default-python-image branch December 11, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants