Rewards-converter #1447
Open
Rewards-converter #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the RewardValue class to handle cash and miles values, making it possible to convert between them. The class has two constructors—one for cash and one for miles. Inside the class, cash is stored as the main value, and the conversion between miles and cash is based on a rate of 0.0035. There are two main methods: getCashValue() returns the cash value, and getMilesValue() converts the cash value back into miles.
After adding the class, I added unit tests to make sure everything works as expected. The tests check that a RewardValue object created with a cash value returns the right cash amount, and one created with miles returns the correct miles amount. I also tested converting cash to miles and miles to cash to ensure the rates (1 / 0.0035 for cash to miles and 0.0035 for miles to cash) are working correctly.