This repository has been archived by the owner on Feb 10, 2022. It is now read-only.
Chore/update mongodb package #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: - MongoClient.connect() was deprecated, now using `new MongoClient().connect()` - MongoClient.collections no longer exists. You have to create a db instance with MongoClient.db() on which the collections() function now exists. The update to mongobd@3 package may result in breaking changes if someone used Mongorito and made use of private/undocuments Mongorito properties (e.g. mongorito's database._connection property)
|
This pull request is great, and I agree with the major version change. I was using the undocumented _connection for example. Please can you bump the version further to "mongodb": "^3.1.2" because of a bug in mongodb's driver. See meteor/meteor#9944 (comment) for detail, although it's regarding Meteor, I've run into the same issue on Mongorito. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
mongodbnpm package to it's latest version.Some small changes were made to Mongorito's code. Specifically:
MongoClient.connect()was deprecated, now usingnew MongoClient().connect()MongoClient.collectionsno longer exists. You have to create a db instance withMongoClient.db()on which thecollections()function now exists.While none of the Mongorito APIs or methods have changes, the update to mongobd@3 package may result in breaking changes if someone used Mongorito with use of private/undocumented Mongorito properties (e.g. mongorito's database._connection property). Therefore might make sense to release this (in conjunction with #205) as a major version release, just in case.
/cc @vadimdemedes 😄