[WIP] Introduce grin apis #1191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😭 Deploy PR Preview e35a263 failed. Build logs |
sighingnow
reviewed
Feb 14, 2023
| class __attribute__((annotate("vineyard"))) ArrowFragment | ||
| : public ArrowFragmentBase, | ||
| public vineyard::BareRegistered< | ||
| ArrowFragment<OID_T, VID_T, VERTEX_MAP_T>> { |
There was a problem hiding this comment.
If I understand it correctly, grin should be an access interface and we don't need some vineyard::Objects there?
I was imaging some thing like
std::shared_ptr<arrow::Fragment> fragment = client.GetObject<vineyard::ArrowFragment>("objectid");
auto g /* grin::Fragment */ = grin::g(fragment);
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information |
andydiwenzhu
force-pushed
the
dev/grin
branch
2 times, most recently
from
fa39361 to
a04fc92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes #issue number