Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always parse versions from rhn config as strings #9589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vzhestkov
Copy link
Contributor

What does this PR change?

web.version.uyuni config value is wrongly parsed as float and 2024.10 became 2024.1.

web.version added as well even if it makes no much sense now, but anyway it should be always string as well.

GUI diff

No difference.

Documentation

  • No documentation needed: only internal and user invisible changes

Test coverage

  • No tests: there are no unit tests for this legacy part of the code

Links

Issue(s): #9414
Port(s): Not needed as Uyuni is the only having such values wrongly parsed as floats

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@vzhestkov vzhestkov requested a review from a team as a code owner December 20, 2024 10:48
@vzhestkov vzhestkov requested review from agraul, ycedres and meaksh and removed request for a team December 20, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants