Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode 127.0.0.1 in salt-api configuration #9570

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Dec 13, 2024

What does this PR change?

Tomcat accesses the salt api using localhost but the salt-api is configured to listen on 127.0.0.1. This works fine until IPv4 is disabled on the host or the 127.0.0.1 line is commented out in /etc/hosts.

In order to make sure both sides are on the same page, use localhost in the salt-api too (bsc#1230865).

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: requires test with disabled IPv4
  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/25318
Port(s): https://github.com/SUSE/spacewalk/pull/26042

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Tomcat accesses the salt api using `localhost` but the salt-api is
configured to listen on `127.0.0.1`. This works fine until IPv4 is
disabled on the host or the `127.0.0.1` line is commented out in
`/etc/hosts`.

In order to make sure both sides are on the same page, use localhost in
the salt-api too (bsc#1230865).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant