Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CoCo Attestation API errors #8999

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

mackdk
Copy link
Contributor

@mackdk mackdk commented Jul 3, 2024

What does this PR change?

This PR fixes:

  • The absence of the attestOnBoot field in the getCoCoAttestationConfig API
  • The error that happens when serializing for the XMLRPC API a ServerCoCoAttestationReport when the attested date is null. This might happen when the report is still PENDING
  • The field attestOnBoot is ignored by setCoCoAttestationConfig API when no configuration exists
  • The error that happens when getCoCoAttestationConfig is called and no configuration is present. Now if the system has coco support an empty configuration is returned.
  • Prevent all the API to work with systems that do not have support for coco attestation. An UnsupportedOperationException is now returned by the API.
  • Return an EntityNotExistsFaultException when the system specified in the call does not match the one from the attestation result when calling getCoCoAttestationResultDetails

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

github-actions bot commented Jul 3, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8999/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8999/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Suggested tests to cover this Pull Request
  • sle_ssh_minion
  • min_salt_migration
  • min_salt_install_with_staging
  • proxy_register_as_minion_with_script
  • min_deblike_salt
  • allcli_overview_systems_details
  • min_salt_formulas
  • min_project_lotus
  • srv_docker_cve_audit
  • minssh_move_from_and_to_proxy
  • min_salt_install_package
  • srv_monitoring
  • min_salt_openscap_audit
  • minkvm_guests
  • min_monitoring
  • min_recurring_action
  • min_salt_minion_details
  • min_rhlike_openscap_audit
  • srv_distro_cobbler
  • min_salt_minions_page
  • min_deblike_salt_install_package
  • min_empty_system_profiles
  • min_cve_id_new_syntax
  • min_ssh_tunnel
  • allcli_sanity
  • min_move_from_and_to_proxy
  • min_ansible_control_node
  • srv_power_management_redfish
  • min_bootstrap_script
  • min_rhlike_monitoring
  • allcli_software_channels_dependencies
  • min_cve_audit
  • min_salt_mgrcompat_state
  • min_config_state_channel
  • srv_reportdb
  • buildhost_bootstrap
  • minssh_salt_install_package
  • allcli_reboot
  • minssh_bootstrap_api
  • proxy_retail_pxeboot_and_mass_import
  • min_rhlike_salt_install_package_and_patch
  • min_deblike_monitoring
  • min_deblike_salt_install_with_staging
  • min_check_patches_install
  • srv_scc_user_credentials
  • srv_cobbler_distro
  • min_rhlike_salt
  • min_salt_lock_packages
  • srv_rename_hostname
  • proxy_branch_network
  • min_bootstrap_api
  • minssh_ansible_control_node
  • srv_first_settings
  • allcli_action_chain
  • min_salt_formulas_advanced
  • srv_cobbler_profile
  • srv_power_management
  • min_salt_user_states
  • allcli_config_channel
  • min_virthost
  • min_deblike_openscap_audit
  • min_action_chain
  • min_config_state_channel_subscriptions
  • min_timezone
  • buildhost_osimage_build_image
  • srv_advanced_search
  • min_activationkey
  • allcli_software_channels
  • min_bootstrap_reactivation
  • srv_maintenance_windows
  • min_salt_pkgset_beacon
  • proxy_as_pod_basic_tests
  • buildhost_docker_build_image
  • sle_minion
  • min_deblike_ssh
  • min_salt_software_states
  • min_rhlike_ssh
  • minssh_action_chain
  • min_custom_pkg_download_endpoint
  • allcli_system_group
  • proxy_cobbler_pxeboot
  • min_bootstrap_ssh_key
  • min_retracted_patches
  • min_change_software_channel

Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found another bug.
SystemHandler.setCoCoAttestationConfig() support the attestOnBoot parameter,
but it set it only when the config is already present. If a config needs to be created that parameter is not set.
Maybe you can fix this as well in this PR?

@mackdk
Copy link
Contributor Author

mackdk commented Jul 3, 2024

I just found another bug. SystemHandler.setCoCoAttestationConfig() support the attestOnBoot parameter, but it set it only when the config is already present. If a config needs to be created that parameter is not set. Maybe you can fix this as well in this PR?

Oh, I didn't notice that. I will fix it.

lucidd
lucidd previously approved these changes Jul 3, 2024
@mackdk
Copy link
Contributor Author

mackdk commented Jul 3, 2024

I added two more fixes, I updated the PR description to describe them accordingly.

@mackdk mackdk added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Jul 5, 2024
@admd admd merged commit 2a39bcd into uyuni-project:master Jul 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API java_lint_checkstyle java_pgsql_tests java merge-candidate Meaning it needs to be considered for merging when the master branch is frozen old-ui xmlrpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants