Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cobbler synchronization when adding system #8992

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

m-czernek
Copy link
Contributor

What does this PR change?

When using the API to add a system, the API explicitly triggers a Cobbler synchronization. This should not be necessary because:

a) Cobbler shouldn't need a sync after adding a system
b) There is the cobbler-sync-default task in SUMA to schedule Cobbler sync periodically.

The default cadence of executing the cobbler-sync-default is every minute. This can be computationally expensive in large environments that add/remove a lot of systems in a short period of time, esp. because one cobbler sync can take longer than 5 minutes.

In this PR, I'm increasing the default schedule from 1 minute to every 5 minutes.

GUI diff

No difference.

Before:

After:

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/23775

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@m-czernek m-czernek requested a review from a team as a code owner July 2, 2024 11:28
@m-czernek m-czernek requested review from wweellddeerr and removed request for a team July 2, 2024 11:28
Copy link
Contributor

github-actions bot commented Jul 2, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8992/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8992/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Suggested tests to cover this Pull Request
  • srv_distro_cobbler
  • srv_cobbler_distro
  • minkvm_guests
  • srv_cobbler_profile
  • srv_power_management

@rjmateus rjmateus requested a review from aaannz July 2, 2024 11:37
@rjmateus
Copy link
Member

rjmateus commented Jul 2, 2024

@aaannz would this somehow affect Retail scenarios?

@aaannz
Copy link
Contributor

aaannz commented Jul 2, 2024

No, we are not using this API and our saltboot system create is not calling sync after anyway.

aaannz
aaannz previously approved these changes Jul 2, 2024
Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but changelog should have bug reference.

Co-authored-by: Ondřej Holeček <[email protected]>
Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@admd admd merged commit 12a9e90 into uyuni-project:master Jul 22, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants