Fix random error during installation of CA certificate (bsc#1227245) #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmateus
approved these changes
Jul 4, 2024
aaannz
approved these changes
Jul 4, 2024
cbosdo
reviewed
Jul 5, 2024
shared/connection.go
Outdated
| args := []string{"exec", podName} | ||
| command, err := c.GetCommand() | ||
| if err != nil { | ||
| log.Fatal().Err(err) |
There was a problem hiding this comment.
better return the error rather than log.Fatal()
cbosdo
approved these changes
Jul 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
When a container is started via systemd, there is a short period when
GetPodName() can fail or GetPodName() succeeds and the following command fails.
It was reported on migration, but I think it can happen on install too. It is more likely on migration, probably because of large writes.
This PR fixes it.
Test coverage
No tests: already covered
DONE
Links
Issue(s):
https://github.com/SUSE/spacewalk/issues/24705
https://bugzilla.suse.com/show_bug.cgi?id=1227245
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!