Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supportconfig proxy #342

Closed
wants to merge 29 commits into from

Conversation

mbussolotto
Copy link
Member

@mbussolotto mbussolotto commented May 29, 2024

What does this PR change?

mgradm/mgrpxy support config improvements. Most of the code is now shared between mgradm and mgrpxy.

mgradm support config tarball content:

  • tarball created by supportconfig command inside the container
  • tarball created by supportconfig command in the host
  • content of all the systemd files and configuration related to the server (systemctl cat uyuni-*)
  • content of all the files binded (it should be empty by now)
  • podman inspect
  • podman logs (it should be empty by now)

mgrpxy support config tarball content on podman:

  • tarball created by supportconfig command in the host
  • content of all the systemd files and configuration related to the proxy (systemctl cat uyuni-*)
  • content of all the files binded (e.g. apache tuning, squid tuning, other conf files)
  • podman inspect
  • podman logs

mgrpxy support config tarball content on k3s:

  • content of all configmap (all the configuration such as apache and squid are embedded there)
  • content of kubectl get pod -o yaml command

Test coverage

  • No tests
  • DONE

Links

Issue(s): #314

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

@mbussolotto mbussolotto force-pushed the supportconfig_proxy branch 6 times, most recently from c1dfe3b to 9ce6960 Compare June 3, 2024 14:22
@mbussolotto mbussolotto marked this pull request as ready for review June 3, 2024 14:28
@mbussolotto mbussolotto requested review from cbosdo and rjmateus and removed request for cbosdo June 4, 2024 15:34
@mbussolotto mbussolotto force-pushed the supportconfig_proxy branch 3 times, most recently from e8110ec to c2cb863 Compare June 5, 2024 09:57
Copy link
Member

@rjmateus rjmateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small considerations, other then that looks good to me

shared/connection.go Outdated Show resolved Hide resolved
shared/kubernetes/support.go Outdated Show resolved Hide resolved
shared/utils/support.go Outdated Show resolved Hide resolved
@mbussolotto mbussolotto force-pushed the supportconfig_proxy branch 2 times, most recently from 2d7c0ce to f8588fc Compare June 7, 2024 09:47
Copy link
Member

@rjmateus rjmateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mgradm/cmd/support/config/extractor.go Outdated Show resolved Hide resolved
mgradm/cmd/support/config/extractor.go Outdated Show resolved Hide resolved
shared/connection.go Outdated Show resolved Hide resolved
shared/kubernetes/support.go Outdated Show resolved Hide resolved
shared/kubernetes/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/utils/support_test.go Show resolved Hide resolved
shared/kubernetes/support.go Outdated Show resolved Hide resolved
shared/kubernetes/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
shared/podman/support.go Outdated Show resolved Hide resolved
@mbussolotto mbussolotto force-pushed the supportconfig_proxy branch 4 times, most recently from 5759a72 to edb3493 Compare June 13, 2024 14:00
@mbussolotto mbussolotto requested a review from cbosdo June 13, 2024 14:35
@mbussolotto mbussolotto linked an issue Jun 14, 2024 that may be closed by this pull request
@cbosdo cbosdo added the SUSE Manager 5.0.1 Candidate PRs for 5.0.1 inclusion label Jul 12, 2024
@cbosdo cbosdo mentioned this pull request Jul 17, 2024
3 tasks
@cbosdo cbosdo closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SUSE Manager 5.0.1 Candidate PRs for 5.0.1 inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a support config command for mgrpxy
3 participants