-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supportconfig proxy #342
Closed
Closed
Supportconfig proxy #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbussolotto
force-pushed
the
supportconfig_proxy
branch
6 times, most recently
from
June 3, 2024 14:22
c1dfe3b
to
9ce6960
Compare
mbussolotto
commented
Jun 3, 2024
mbussolotto
requested review from
cbosdo and
rjmateus
and removed request for
cbosdo
June 4, 2024 15:34
mbussolotto
force-pushed
the
supportconfig_proxy
branch
3 times, most recently
from
June 5, 2024 09:57
e8110ec
to
c2cb863
Compare
rjmateus
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small considerations, other then that looks good to me
mbussolotto
force-pushed
the
supportconfig_proxy
branch
2 times, most recently
from
June 7, 2024 09:47
2d7c0ce
to
f8588fc
Compare
rjmateus
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cbosdo
reviewed
Jun 10, 2024
mbussolotto
force-pushed
the
supportconfig_proxy
branch
from
June 11, 2024 12:47
c662bc8
to
24dfb51
Compare
cbosdo
reviewed
Jun 12, 2024
mbussolotto
force-pushed
the
supportconfig_proxy
branch
4 times, most recently
from
June 13, 2024 14:00
5759a72
to
edb3493
Compare
mbussolotto
force-pushed
the
supportconfig_proxy
branch
from
June 13, 2024 14:38
7f2ec5b
to
2488d19
Compare
Co-authored-by: Cedric Bosdonnat <[email protected]>
mbussolotto
force-pushed
the
supportconfig_proxy
branch
from
July 10, 2024 15:15
dde8797
to
c6180c2
Compare
cbosdo
approved these changes
Jul 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
mgradm/mgrpxy support config
improvements. Most of the code is now shared betweenmgradm
andmgrpxy
.mgradm support config
tarball content:supportconfig
command inside the containersupportconfig
command in the hostsystemctl cat uyuni-*
)mgrpxy support config
tarball content on podman:supportconfig
command in the hostsystemctl cat uyuni-*
)mgrpxy support config
tarball content on k3s:kubectl get pod -o yaml
commandTest coverage
Links
Issue(s): #314
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Before you merge
Check How to branch and merge properly!