Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the GPG key location #3090

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Changed the GPG key location #3090

merged 4 commits into from
Jul 10, 2024

Conversation

0rnela
Copy link
Contributor

@0rnela 0rnela commented Jun 18, 2024 •
edited
Loading

@keichwa
Copy link
Contributor

keichwa commented Jun 18, 2024

@0rnela I guess, the user will create the GPG key on the container host. If that's the case, the user will have to copy it with mgradm gpg add to the container, probably during the first procedure of this file. That's how I understand Michele's comment in the referenced spacewalk issue.

keichwa
keichwa requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@keichwa keichwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment in the "Conversation" tab.

@0rnela 0rnela requested review from keichwa and jcayouette July 3, 2024 12:49
keichwa
keichwa reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@keichwa keichwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unfortunately do not know whether the cp step inside of the container is superfluous. Maybe, mgradm gpg add can copy it to the final destination in one go.

modules/client-configuration/pages/autoinst-owngpgkey.adoc Outdated Show resolved Hide resolved
@0rnela 0rnela requested review from keichwa and mbussolotto and removed request for mbussolotto July 8, 2024 14:13
mbussolotto
mbussolotto reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it (maybe @aaannz can provide some feedback) but it should work as described in the comment...if not it's not a doc issue but a bug :)

modules/client-configuration/pages/autoinst-owngpgkey.adoc Outdated Show resolved Hide resolved
@0rnela
Copy link
Contributor Author

0rnela commented Jul 9, 2024

newGPGprocedure.pdf

@0rnela 0rnela requested a review from mbussolotto July 9, 2024 14:06
mbussolotto
mbussolotto approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

keichwa
keichwa approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@keichwa keichwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@0rnela 0rnela merged commit 265765f into master Jul 10, 2024
1 check failed
@0rnela 0rnela deleted the leftoverBookFixes-01 branch July 10, 2024 09:29
@0rnela
Copy link
Contributor Author

0rnela commented Jul 10, 2024

Thank you all.

@0rnela 0rnela mentioned this pull request Jul 10, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keichwa keichwa keichwa approved these changes

@mbussolotto mbussolotto mbussolotto approved these changes

@jcayouette jcayouette jcayouette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0rnela @keichwa @mbussolotto @jcayouette