Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document signing of Git Commits #33

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Document signing of Git Commits #33

merged 5 commits into from
Jul 4, 2024

Conversation

juliogonzalez
Copy link
Member

No description provided.

@juliogonzalez juliogonzalez requested a review from nodeg July 4, 2024 09:25
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nodeg nodeg added the documentation Improvements or additions to documentation label Jul 4, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nodeg
Copy link
Member

nodeg commented Jul 4, 2024

With your last commit, you broke the list layout:

image

compared to

image

@juliogonzalez
Copy link
Member Author

juliogonzalez commented Jul 4, 2024

imagen

@juliogonzalez juliogonzalez requested a review from nodeg July 4, 2024 10:09
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list layout is still "broken", but it's fine. We have more Markdown issues in the README.
Thank you, Julio.

@juliogonzalez
Copy link
Member Author

The list layout is still "broken", but it's fine. We have more Markdown issues in the README. Thank you, Julio.

What's broken? I see it correctly on the GitHub preview.

@juliogonzalez
Copy link
Member Author

BTW @nodeg, if we really want to enforce such rules, there should be actions telling the users about that (at every repo where there're markdown files :-))

In the end we are talking about linting, not about syntax users, and most contributors (myself included), are not really aware of all those rules, and won't remember about them for casual contributions.

@nodeg
Copy link
Member

nodeg commented Jul 4, 2024

Makes sense. An idea would be to have a GitHub Actions for linting Markdown files when opening a Pull Request.

@juliogonzalez juliogonzalez merged commit 04a90e8 into master Jul 4, 2024
1 check passed
@juliogonzalez juliogonzalez deleted the commit-signing branch July 4, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants