Controller: update Ruby to 3.3 for HEAD/Uyuni/Uyuni Podman/5.x #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodeg
force-pushed
the
qe-update-ruby
branch
7 times, most recently
from
b83f6b5
to
86810b5
Compare
nodeg
force-pushed
the
qe-update-ruby
branch
3 times, most recently
from
a744696
to
95db7fb
Compare
nodeg
force-pushed
the
qe-update-ruby
branch
2 times, most recently
from
0a2eaaf
to
6ba196b
Compare
nodeg
force-pushed
the
qe-update-ruby
branch
3 times, most recently
from
727cdda
to
586777c
Compare
nodeg
changed the title
nodeg
force-pushed
the
qe-update-ruby
branch
6 times, most recently
from
5d76f51
to
f9d521b
Compare
srbarrios
approved these changes
Aug 22, 2024
srbarrios
approved these changes
Aug 22, 2024
NamelessOne91
approved these changes
Aug 22, 2024
ktsamis
approved these changes
Aug 22, 2024
vandabarata
approved these changes
Aug 22, 2024
maximenoel8
approved these changes
Aug 22, 2024
srbarrios
changed the title
srbarrios
approved these changes
Aug 23, 2024
nodeg
changed the title
nodeg
force-pushed
the
qe-update-ruby
branch
3 times, most recently
from
17f2403
to
a7ab0f4
Compare
nodeg
force-pushed
the
qe-update-ruby
branch
7 times, most recently
from
9291f20
to
d493fde
Compare
This will - update the Ruby version on the controller to 3.3 - build Twopence from source since there is no way we can build it in OBS with Ruby 3 on openSUSE Leap 15.5/15.6 - add the `product_version` variable to the controller grain, that we will use, to still be able to use Ruby 2.5 on 4.3 - fix the CI tests by including the checked `product_version` as a variable - update the `cucumber-html-reporter` version See SUSE/spacewalk#17431 Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
This reverts commit d6558ea.
nodeg
force-pushed
the
qe-update-ruby
branch
from
d493fde
to
b70df85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Prerequisite for uyuni-project/uyuni#6559 / uyuni-project/uyuni#9181. See also the issue https://github.com/SUSE/spacewalk/issues/17431. I only merge this PR, once everything in Uyuni is ready.
This will
build Twopence from source since there is no way we can build it in OBS with Ruby 3 on openSUSE Leap 15.5/15.6product_versionvariable to the controller grain, that we will use, to still be able to use Ruby 2.5 on 4.3product_versionas a variableLater on, I will also update Ruby in spacewalk for 4.3, but first we need it in master and giving it some time there.
TODO
Links