Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the injected repositories during the cloud-init phase once we finish that phase #1218

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Removing the injected repositories during the cloud-init phase once we finish that phase #1218

wants to merge 2 commits into from

Conversation

srbarrios
Copy link
Member

@srbarrios srbarrios commented Nov 30, 2022 •
edited
Loading

What does this PR change?

Card: https://github.com/SUSE/spacewalk/issues/19697

This PR clean-up all the injected repositories once the cloud-init phase finish.

It depends on: #1219

@srbarrios srbarrios requested a review from rjmateus November 30, 2022 15:45
@srbarrios srbarrios marked this pull request as draft November 30, 2022 15:58
@srbarrios srbarrios removed the request for review from rjmateus November 30, 2022 15:59
@rjmateus rjmateus requested review from moio, avshiliaev and rjmateus and removed request for moio, avshiliaev and rjmateus November 30, 2022 17:41
@srbarrios srbarrios changed the title Removing all repositories in RH-Like and SUSE systems after cloud-init Removing all repositories in all images after cloud-init phase Dec 1, 2022
@srbarrios srbarrios marked this pull request as ready for review December 1, 2022 14:04
@srbarrios srbarrios force-pushed the rm-temp-repos-cloudinit branch 2 times, most recently from 40a9049 to 6c8ce33 Compare December 1, 2022 14:40
@srbarrios srbarrios changed the title Removing all repositories in all images after cloud-init phase Removing the injected repositories during the cloud-init phase once we finish that phase Dec 1, 2022
Bischoff
Bischoff approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice decoupling of responsibilities, thank you

maybe we also need something similar at the end of sumaform, not sure

@srbarrios srbarrios mentioned this pull request Dec 1, 2022
Merged
@srbarrios srbarrios force-pushed the rm-temp-repos-cloudinit branch from 6c8ce33 to cf4aa1d Compare December 1, 2022 16:45
rjmateus
rjmateus reviewed Dec 2, 2022
View reviewed changes
Copy link
Member

@rjmateus rjmateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments

backend_modules/libvirt/host/user_data.yaml Outdated Show resolved Hide resolved
backend_modules/libvirt/host/user_data.yaml Outdated Show resolved Hide resolved
@srbarrios srbarrios mentioned this pull request Dec 15, 2022
Merged
@srbarrios srbarrios marked this pull request as draft December 21, 2022 13:11
@srbarrios srbarrios force-pushed the rm-temp-repos-cloudinit branch from cf4aa1d to 2164ecc Compare January 4, 2023 09:46
@srbarrios srbarrios force-pushed the rm-temp-repos-cloudinit branch from 2164ecc to 935ed61 Compare January 4, 2023 09:48
@maximenoel8 maximenoel8 deleted the rm-temp-repos-cloudinit branch May 11, 2023 23:31
@maximenoel8 maximenoel8 restored the rm-temp-repos-cloudinit branch May 11, 2023 23:31
@srbarrios
Copy link
Member Author

srbarrios commented Aug 21, 2024 •
edited
Loading

I'm not sure why this PR was closed by @maximenoel8.
I'm gonna open the PR again, because we might still want to integrate these code changes, but I will not be working on this now.

@srbarrios srbarrios reopened this Aug 21, 2024
@srbarrios srbarrios self-assigned this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmateus rjmateus rjmateus left review comments

@avshiliaev avshiliaev avshiliaev approved these changes

@Bischoff Bischoff Bischoff approved these changes

Assignees

@srbarrios srbarrios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srbarrios @Bischoff @rjmateus @avshiliaev @maximenoel8