[hotfix] Add const getter of PowerPort in PowerControlUnit #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conjikidow
added
priority::medium
conjikidow
requested review from
200km,
ogoogo,
Hiro-0110,
seki-hiro,
suzuki-toshihir0 and
t-hosonuma
and removed request for
a team
200km
approved these changes
Aug 22, 2024
200km
changed the title
conjikidow
added a commit
that referenced
this pull request
Aug 23, 2024
Merge main into develop for hotfix #670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
NA
Description
PowerControlUnitにおいて，PowerPortの getter であるGetPowerPortに const な overload member function を追加した。PowerPortはGetVoltage_Vなどの getter を持つが，PowerControlUnit::GetPowerPortが const でないとGetLogValueなどの const function から呼び出すことができず不便であったため。Test results
ビルドについてはCIで確認可能。
動作についてはuserプロジェクトで確認済み。
Impact
既存のものへの影響はない想定。
Supplementary information
NA