Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geopotential partial derivative #466

Merged
merged 12 commits into from
Aug 15, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Aug 1, 2023

Overview

Add geopotential partial derivative

Issue

NA

Details

Add a function to calculate the partial derivative of geopotential.

Validation results

I confirmed the numerical and analytical calculations can derive the same partial derivative values. Please see the test code for more details.

https://github.com/ut-issl/s2e-core/actions/runs/5855692008/job/15873979685?pr=466#step:12:182

Scope of influence

Minor update

Supplement

NA

Note

NA

@200km 200km added priority::medium priority medium disturbance disturbance calculation minor update add functionality in a backwards compatible manner labels Aug 1, 2023
@200km 200km added this to the Minor update v6.3.0 milestone Aug 1, 2023
@200km 200km self-assigned this Aug 1, 2023
@200km 200km requested review from sksat and a team as code owners August 1, 2023 06:40
@200km 200km requested review from seki-hiro, suzuki-toshihir0 and conjikidow and removed request for a team August 1, 2023 06:40
@200km 200km changed the title WIP: Add geopotential partial derivative Add geopotential partial derivative Aug 14, 2023
Copy link
Member

@seki-hiro seki-hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないと思います。

@200km 200km merged commit d704d49 into develop Aug 15, 2023
11 checks passed
@200km 200km deleted the feature/add-partial-geopotential-partial-derivative branch August 15, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disturbance disturbance calculation minor update add functionality in a backwards compatible manner priority::medium priority medium
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants