generated from ut-issl/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geopotential partial derivative #466
Merged
200km
merged 12 commits into
develop
from
feature/add-partial-geopotential-partial-derivative
Aug 15, 2023
Merged
Add geopotential partial derivative #466
200km
merged 12 commits into
develop
from
feature/add-partial-geopotential-partial-derivative
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200km
added
priority::medium
priority medium
disturbance
disturbance calculation
minor update
add functionality in a backwards compatible manner
labels
Aug 1, 2023
200km
requested review from
seki-hiro,
suzuki-toshihir0 and
conjikidow
and removed request for
a team
August 1, 2023 06:40
200km
changed the title
WIP: Add geopotential partial derivative
Add geopotential partial derivative
Aug 14, 2023
seki-hiro
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
問題ないと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
disturbance
disturbance calculation
minor update
add functionality in a backwards compatible manner
priority::medium
priority medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add geopotential partial derivative
Issue
NA
Details
Add a function to calculate the partial derivative of geopotential.
Validation results
I confirmed the numerical and analytical calculations can derive the same partial derivative values. Please see the test code for more details.
https://github.com/ut-issl/s2e-core/actions/runs/5855692008/job/15873979685?pr=466#step:12:182
Scope of influence
Minor update
Supplement
NA
Note
NA