Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EL low note telemetry #318

Merged
merged 6 commits into from
May 25, 2024
Merged

Add EL low note telemetry #318

merged 6 commits into from
May 25, 2024

Conversation

conjikidow
Copy link
Member

@conjikidow conjikidow commented May 24, 2024

Issue

詳細

EL lowのテレメにnoteを追加した(HK_GEN.OBC.EL.LATEST_LOW_EVENT.NOTE

検証結果

ビルドチェック (どちらもチェック)

  • SILSでのビルドチェックに通った(CIで確認)
  • vMicroでのビルドチェックに通った

動作確認チェック (いずれかをチェック)

  • SILSでアルゴリズムが想定通りに動いた
  • 実機でアルゴリズムが想定通りに動いた
  • (テレコマ試験の場合)コマンドファイルを使った試験をパスした

試験結果詳細記述場所 or 詳細ログ保存場所へのリンク

noteに値が入ることが確認できた。
image

補足

NA

@conjikidow conjikidow added 🚗 priority::low priority low 🐟 patch Patch Update labels May 24, 2024
@conjikidow conjikidow added this to the v10.0.0 Major update milestone May 24, 2024
@conjikidow conjikidow self-assigned this May 24, 2024
@conjikidow conjikidow requested review from sksat and a team as code owners May 24, 2024 16:54
@conjikidow conjikidow requested review from 200km, seki-hiro, suzuki-toshihir0 and t-hosonuma and removed request for a team May 24, 2024 16:54
Comment on lines -53 to +55
,TORQUE.IN_TARGET_B.X_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[0]),PACKET,143,0,32,NONE,,,,,,,,目標内力トルク 機体座標X [Nm],
,TORQUE.IN_TARGET_B.Y_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[1]),PACKET,147,0,32,NONE,,,,,,,,目標内力トルク 機体座標Y [Nm],
,TORQUE.IN_TARGET_B.Z_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[2]),PACKET,151,0,32,NONE,,,,,,,,目標内力トルク 機体座標Z [Nm],
,TORQUE.IN_TARGET.B_X_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[0]),PACKET,143,0,32,NONE,,,,,,,,目標内力トルク 機体座標X [Nm],
,TORQUE.IN_TARGET.B_Y_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[1]),PACKET,147,0,32,NONE,,,,,,,,目標内力トルク 機体座標Y [Nm],
,TORQUE.IN_TARGET.B_Z_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[2]),PACKET,151,0,32,NONE,,,,,,,,目標内力トルク 機体座標Z [Nm],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本PRとは直接関係ないものの,命名が揃っていないことに気づいたため修正した

@conjikidow conjikidow linked an issue May 24, 2024 that may be closed by this pull request
@conjikidow conjikidow merged commit 9ff22ee into develop May 25, 2024
9 of 11 checks passed
@conjikidow conjikidow deleted the feature/add-el-low-note-tlm branch May 25, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚗 priority::low priority low 🐟 patch Patch Update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EL low noteのテレメの追加
2 participants