generated from ut-issl/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EL low note telemetry #318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conjikidow
requested review from
200km,
seki-hiro,
suzuki-toshihir0 and
t-hosonuma
and removed request for
a team
May 24, 2024 16:54
conjikidow
commented
May 24, 2024
Comment on lines
-53
to
+55
,TORQUE.IN_TARGET_B.X_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[0]),PACKET,143,0,32,NONE,,,,,,,,目標内力トルク 機体座標X [Nm], | ||
,TORQUE.IN_TARGET_B.Y_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[1]),PACKET,147,0,32,NONE,,,,,,,,目標内力トルク 機体座標Y [Nm], | ||
,TORQUE.IN_TARGET_B.Z_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[2]),PACKET,151,0,32,NONE,,,,,,,,目標内力トルク 機体座標Z [Nm], | ||
,TORQUE.IN_TARGET.B_X_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[0]),PACKET,143,0,32,NONE,,,,,,,,目標内力トルク 機体座標X [Nm], | ||
,TORQUE.IN_TARGET.B_Y_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[1]),PACKET,147,0,32,NONE,,,,,,,,目標内力トルク 機体座標Y [Nm], | ||
,TORQUE.IN_TARGET.B_Z_Nm,float,(float)(aocs_manager->internal_torque_target_body_Nm[2]),PACKET,151,0,32,NONE,,,,,,,,目標内力トルク 機体座標Z [Nm], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
本PRとは直接関係ないものの,命名が揃っていないことに気づいたため修正した
Closed
200km
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
詳細
EL lowのテレメにnoteを追加した(
HK_GEN.OBC.EL.LATEST_LOW_EVENT.NOTE
)検証結果
ビルドチェック (どちらもチェック)
動作確認チェック (いずれかをチェック)
試験結果詳細記述場所 or 詳細ログ保存場所へのリンク
noteに値が入ることが確認できた。
補足
NA