Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OEM enum to avoid error in c2a-enum loader #153

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix OEM enum to avoid error in c2a-enum loader #153

merged 1 commit into from
Aug 4, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Aug 2, 2023 •
edited
Loading

Issue

詳細

#28 で書いたようにc2a-enum loaderでのエラーを回避するための処置

検証結果

ビルドチェック (どちらもチェック)

  • SILSでのビルドチェックに通った(CIで確認)
  • vMicroでのビルドチェックに通った -> 微修正なので必要ないと思います。

動作確認チェック (いずれかをチェック)

  • SILSでアルゴリズムが想定通りに動いた
  • 実機でアルゴリズムが想定通りに動いた
  • (テレコマ試験の場合)コマンドファイルを使った試験をパスした

試験結果詳細記述場所 or 詳細ログ保存場所へのリンク

#150 ではこの修正を加えて動いている

補足

NA

@200km 200km added ✈️ priority::medium priority medium 🐟 patch Patch Update 🔧 tools Tools labels Aug 2, 2023
@200km 200km requested a review from t-hosonuma August 2, 2023 20:07
@200km 200km self-assigned this Aug 2, 2023
@200km 200km requested review from sksat and a team as code owners August 2, 2023 20:07
@200km 200km requested review from seki-hiro, suzuki-toshihir0 and conjikidow and removed request for a team August 2, 2023 20:07
@200km 200km mentioned this pull request Aug 3, 2023
Closed
2 tasks
suzuki-toshihir0
suzuki-toshihir0 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@suzuki-toshihir0 suzuki-toshihir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

特に問題ないと思いますので，approveします．

@200km 200km merged commit 8934fdf into main Aug 4, 2023
13 of 16 checks passed
@200km 200km deleted the hotfix/fix-oem-enum branch August 4, 2023 08:25
200km added a commit that referenced this pull request Aug 7, 2023
@200km
Merge pull request #158 from ut-issl/main
1247177 
Main merge for Hotfix #153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-toshihir0 suzuki-toshihir0 suzuki-toshihir0 approved these changes

@t-hosonuma t-hosonuma Awaiting requested review from t-hosonuma

@sksat sksat Awaiting requested review from sksat sksat is a code owner

@seki-hiro seki-hiro Awaiting requested review from seki-hiro seki-hiro is a code owner automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow is a code owner automatically assigned from ut-issl/aocs

Assignees

@200km 200km

Labels
✈️ priority::medium priority medium 🐟 patch Patch Update 🔧 tools Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@200km @suzuki-toshihir0