added forceDepthFirst flag to closure and closureStar for testing purposes #237
Conversation
| * @throws UnsupportedOperationException when the receiver is not a binary relation | ||
| */ | ||
| public default C closure() { | ||
| public default C closure(boolean forceDepthFirst) { |
There was a problem hiding this comment.
Do we need to break our public contract for this? How about still having the regular function in here?
There was a problem hiding this comment.
Right, yes we should have a default version.
There was a problem hiding this comment.
how about we give it an enum? or a way to say: auto vs DFS/BFS? so a user can say: hey, this is BFS, so let's go for that. Since even for big collections, there are graphs where BFS is better.
There was a problem hiding this comment.
This is only for testing purposes. We can never give this to the rascal user anyway. And to be honest, there are dozens of algorithms we still have to try. It's quite possible that the distinction between DFS and bfs becomes a lot more vague.
Test Results 55 files - 41 55 suites - 41 3m 3s ⏱️ - 4m 12s Results for commit 849c655. ± Comparison against base commit 073dbdd. This pull request removes 64614 and adds 200 tests. Note that renamed tests count towards both. |
This does not terminate while running the tests yet. Probably an issue with the IBool value generator?